🐛 Fix incorrect fieldSpecs paths #211
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XS
|
/hold |
furkatgofurov7
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Merging it since it is straightforward change, thanks @Fedosin.
/approve
/lgtm
|
/check-cla |
|
Prow seems to be lagging today :) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 3d4c538cffa73d757efcccde7c917f62315a9b62
|
k8s-ci-robot
added
approved
Several paths for name references are not correct and therefore kustomize doesn't substitute right values there. This PR fixes it to make kustomize works correctly.
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -16,7 +16,7 @@ spec: | |||
| clientConfig: | |||
| caBundle: Cg== | |||
| service: | |||
| name: webhook-service | |||
| name: capi-operator-webhook-service | |||
There was a problem hiding this comment.
where is this service being defined?
There was a problem hiding this comment.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e04ab5f26450ebce7cbcf076ed0d67785ea11215
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Several paths for name references are not correct and therefore kustomize doesn't substitute right values there.
This PR fixes it and makes kustomize works correctly.
Reference patch: https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/config/crd/patches/webhook_in_coreproviders.yaml#L18
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #