Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix incorrect fieldSpecs paths #211

Merged
merged 1 commit into from
Aug 11, 2023
Merged

🐛 Fix incorrect fieldSpecs paths #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/crd/kustomizeconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ nameReference:
fieldSpecs:
- kind: CustomResourceDefinition
group: apiextensions.k8s.io
path: spec/conversion/webhookClientConfig/service/name
path: spec/conversion/webhook/clientConfig/service/name

namespace:
- kind: CustomResourceDefinition
group: apiextensions.k8s.io
path: spec/conversion/webhookClientConfig/service/namespace
path: spec/conversion/webhook/clientConfig/service/namespace
create: false

varReference:
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/resources/full-chart-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this service being defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is here https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/resources/full-chart-install.yaml#L6421

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down Expand Up @@ -1577,7 +1577,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down Expand Up @@ -3140,7 +3140,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down Expand Up @@ -4701,7 +4701,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down