Skip to content

Commit

Permalink
fix incorrect fieldSpecs paths
Browse files Browse the repository at this point in the history
Several paths for name references are not correct and therefore
kustomize doesn't substitute right values there.

This PR fixes it to make kustomize works correctly.
  • Loading branch information
Fedosin committed Aug 10, 2023
1 parent 7fd7add commit 9bac724
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions config/crd/kustomizeconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ nameReference:
fieldSpecs:
- kind: CustomResourceDefinition
group: apiextensions.k8s.io
path: spec/conversion/webhookClientConfig/service/name
path: spec/conversion/webhook/clientConfig/service/name

namespace:
- kind: CustomResourceDefinition
group: apiextensions.k8s.io
path: spec/conversion/webhookClientConfig/service/namespace
path: spec/conversion/webhook/clientConfig/service/namespace
create: false

varReference:
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/resources/full-chart-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down Expand Up @@ -1577,7 +1577,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down Expand Up @@ -3140,7 +3140,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down Expand Up @@ -4701,7 +4701,7 @@ spec:
clientConfig:
caBundle: Cg==
service:
name: webhook-service
name: capi-operator-webhook-service
namespace: 'capi-operator-system'
path: /convert
conversionReviewVersions:
Expand Down

0 comments on commit 9bac724

Please sign in to comment.