feat(sdk): add noun aliasing to cli #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/test all |
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
cb34421 to
6ab2469
Compare
|
/test all |
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
6ab2469 to
5ddb6b5
Compare
|
/test all |
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
5ddb6b5 to
1a06bf6
Compare
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
2 times, most recently
from
efc4c8e to
082d15f
Compare
|
/test all |
1 task
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
2 times, most recently
from
3e51034 to
4842b3d
Compare
|
/test all |
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
4842b3d to
18d41c0
Compare
|
/test all |
|
/retest |
1 similar comment
|
/retest |
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
18d41c0 to
0e1abcf
Compare
1 task
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
231294c to
b76ceec
Compare
chensun
reviewed
Apr 22, 2022
sdk/python/kfp/cli/cli_test.py
Outdated
|
|
||
| from click import testing | ||
|
|
||
| # Docker is an optional install, but we need the import to succeed for tests, |
There was a problem hiding this comment.
In that case, docker should be test dependency, maybe add it to requirements-test.txt? WDYT?
There was a problem hiding this comment.
Good idea. I did two things:
- I made the intent of the mock more clear with b5cee1c.
- I added
docker(andmock, which had a TODO note) to therequirements-test.txtfile with
c1700b4. I chose not to pin the versions because we don't pin the versions in the other places these packages are/were listed (presubmit-tests-sdk.shformockandsetup.pyfordocker.)
connor-mccarthy
force-pushed
the
alias-command-plurality
branch
from
63726ef to
c1700b4
Compare
1 task
|
/lgtm Great work! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ji-yaqi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
jagadeeshi2i
pushed a commit
to jagadeeshi2i/pipelines
that referenced
this pull request
May 11, 2022
* allow both singular and plural versions of nouns * use command table for client creation * cleanup * simplify docker mock * add docker to test requirements; clean up existing requirements
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
* allow both singular and plural versions of nouns * use command table for client creation * cleanup * simplify docker mock * add docker to test requirements; clean up existing requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Aliases all commands to their plurals also. E.g.,
kfp runandkfp runsboth work.Checklist:
repository.