-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
1 parent
5aaf6a4
commit 6ab2469
Showing
6 changed files
with
168 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# Copyright 2022 The Kubeflow Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import functools | ||
import unittest | ||
|
||
from click import testing | ||
from kfp.cli import cli | ||
|
||
|
||
class TestCli(unittest.TestCase): | ||
|
||
def setUp(self): | ||
runner = testing.CliRunner() | ||
self.invoke = functools.partial( | ||
runner.invoke, cli=cli.cli, catch_exceptions=False, obj={}) | ||
|
||
def test_aliases_singular(self): | ||
result = self.invoke(args=["run"]) | ||
self.assertEqual(result.exit_code, 0) | ||
|
||
def test_aliases_plural(self): | ||
result = self.invoke(args=["runs"]) | ||
self.assertEqual(result.exit_code, 0) | ||
|
||
def test_aliases_fails(self): | ||
result = self.invoke(args=["runss"]) | ||
self.assertEqual(result.exit_code, 2) | ||
self.assertEqual("Error: Unrecognized command 'runss'\n", result.output) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Copyright 2022 The Kubeflow Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright 2022 The Kubeflow Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from typing import List, Tuple, Union | ||
|
||
import click | ||
|
||
|
||
class AliasedPluralsGroup(click.Group): | ||
|
||
def get_command(self, ctx: click.Context, cmd_name: str) -> click.Command: | ||
regular = click.Group.get_command(self, ctx, cmd_name) | ||
if regular is not None: | ||
return regular | ||
elif cmd_name.endswith("s"): | ||
singular = click.Group.get_command(self, ctx, cmd_name[:-1]) | ||
if singular is not None: | ||
return singular | ||
raise click.UsageError(f"Unrecognized command '{cmd_name}'") | ||
|
||
def resolve_command( | ||
self, ctx: click.Context, args: List[str] | ||
) -> Tuple[Union[str, None], Union[click.Command, None], List[str]]: | ||
# always return the full command name | ||
_, cmd, args = super().resolve_command(ctx, args) | ||
return cmd.name, cmd, args # type: ignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Copyright 2022 The Kubeflow Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import unittest | ||
|
||
import click | ||
from click import testing | ||
from kfp.cli.utils import aliased_plurals_group | ||
|
||
|
||
@click.group(cls=aliased_plurals_group.AliasedPluralsGroup) | ||
def cli(): | ||
pass | ||
|
||
|
||
@cli.command() | ||
def command(): | ||
click.echo('Called command.') | ||
|
||
|
||
class TestAliasedPluralsGroup(unittest.TestCase): | ||
|
||
def setUp(self): | ||
self.runner = testing.CliRunner() | ||
|
||
def test_aliases_default_success(self): | ||
result = self.runner.invoke(cli, ['command']) | ||
self.assertEqual(result.exit_code, 0) | ||
self.assertEqual(result.output, "Called command.\n") | ||
|
||
def test_aliases_plural_success(self): | ||
result = self.runner.invoke(cli, ['commands']) | ||
self.assertEqual(result.exit_code, 0) | ||
self.assertEqual(result.output, "Called command.\n") | ||
|
||
def test_aliases_failure(self): | ||
result = self.runner.invoke(cli, ['commandss']) | ||
self.assertEqual(result.exit_code, 2) | ||
self.assertEqual("Error: Unrecognized command 'commandss'\n", | ||
result.output) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |