-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow output artifact store configuration (vs hard coded) #1234
Comments
There is already a PR for this. But we'd like to solve this in a different way - by having an in-cluster configMap with the storage configuration. Argo already supports that, but we're hesitating to use that mechanism since KF Pipelines might not be the exclusive user of the Argo controller. Fortunately, the problem will be solved in Argo 2.4 (per-pipeline configMap reference) |
@Ark-kun a mechanism like config map sounds better, it will also make the YAMLs cleaner, currently u get the same 27 lines added to every container, see below, would be nice to hide it: outputs:
artifacts:
- name: mlpipeline-ui-metadata
path: /mlpipeline-ui-metadata.json
s3:
accessKeySecret:
key: accesskey
name: mlpipeline-minio-artifact
bucket: mlpipeline
endpoint: minio-service.kubeflow:9000
insecure: true
key: runs/{{workflow.uid}}/{{pod.name}}/mlpipeline-ui-metadata.tgz
secretKeySecret:
key: secretkey
name: mlpipeline-minio-artifact
- name: mlpipeline-metrics
path: /mlpipeline-metrics.json
s3:
accessKeySecret:
key: accesskey
name: mlpipeline-minio-artifact
bucket: mlpipeline
endpoint: minio-service.kubeflow:9000
insecure: true
key: runs/{{workflow.uid}}/{{pod.name}}/mlpipeline-metrics.tgz
secretKeySecret:
key: secretkey
name: mlpipeline-minio-artifact |
Fixed by #1297 |
PiperOrigin-RevId: 627500444 **Description of your changes:** **Checklist:** - [ ] The title for your pull request (PR) should follow our title convention. [Learn more about the pull request title convention used in this repository](https://github.com/kubeflow/pipelines/blob/master/CONTRIBUTING.md#pull-request-title-convention). <!-- PR titles examples: * `fix(frontend): fixes empty page. Fixes kubeflow#1234` Use `fix` to indicate that this PR fixes a bug. * `feat(backend): configurable service account. Fixes kubeflow#1234, fixes kubeflow#1235` Use `feat` to indicate that this PR adds a new feature. * `chore: set up changelog generation tools` Use `chore` to indicate that this PR makes some changes that users don't need to know. * `test: fix CI failure. Part of kubeflow#1234` Use `part of` to indicate that a PR is working on an issue, but shouldn't close the issue when merged. -->
* chore(components): Drop GCPC Python 3.7 PiperOrigin-RevId: 627500444 **Description of your changes:** **Checklist:** - [ ] The title for your pull request (PR) should follow our title convention. [Learn more about the pull request title convention used in this repository](https://github.com/kubeflow/pipelines/blob/master/CONTRIBUTING.md#pull-request-title-convention). <!-- PR titles examples: * `fix(frontend): fixes empty page. Fixes #1234` Use `fix` to indicate that this PR fixes a bug. * `feat(backend): configurable service account. Fixes #1234, fixes #1235` Use `feat` to indicate that this PR adds a new feature. * `chore: set up changelog generation tools` Use `chore` to indicate that this PR makes some changes that users don't need to know. * `test: fix CI failure. Part of #1234` Use `part of` to indicate that a PR is working on an issue, but shouldn't close the issue when merged. --> * drop support python3.7 * fix test Signed-off-by: rickyxie0929 <[email protected]> * fix test Signed-off-by: rickyxie0929 <[email protected]> * fix test Signed-off-by: rickyxie0929 <[email protected]> * fix test Signed-off-by: rickyxie0929 <[email protected]> * fix tes Signed-off-by: rickyxie0929 <[email protected]> * fix test Signed-off-by: rickyxie0929 <[email protected]> * fix test Signed-off-by: rickyxie0929 <[email protected]> * remove kfp related Signed-off-by: rickyxie0929 <[email protected]> * remove kfp related Signed-off-by: rickyxie0929 <[email protected]> * just kfp change Signed-off-by: rickyxie0929 <[email protected]> * only change in kubernetes_platform/python/setup.py Signed-off-by: rickyxie0929 <[email protected]> * only change in init.py Signed-off-by: rickyxie0929 <[email protected]> * change Signed-off-by: rickyxie0929 <[email protected]> * change Signed-off-by: rickyxie0929 <[email protected]> * Update release Signed-off-by: rickyxie0929 <[email protected]> * Update base image Signed-off-by: rickyxie0929 <[email protected]> * change test python 3.7 to python 3.8 Signed-off-by: rickyxie0929 <[email protected]> * update golden snapshot Signed-off-by: rickyxie0929 <[email protected]> * update yaml to python3.8 under kubernetes_platform/python/test/snapshot/data/toleration.yaml Signed-off-by: rickyxie0929 <[email protected]> * update yaml python 3.8 for sdk/python/test_data/pipelines/parallelfor_fan_in Signed-off-by: rickyxie0929 <[email protected]> * update yaml to fix tests Signed-off-by: rickyxie0929 <[email protected]> * Update Readme Signed-off-by: rickyxie0929 <[email protected]> * Update kubernetes_setup python version Signed-off-by: rickyxie0929 <[email protected]> * Update readme Signed-off-by: rickyxie0929 <[email protected]> --------- Signed-off-by: rickyxie0929 <[email protected]>
it seems like the output artifacts are always stored in a specific minio service, port, namespace, bucket, secrets, etc (
minio-service.kubeflow:9000
).see:
pipelines/sdk/python/kfp/compiler/_op_to_template.py
Line 148 in f40a22a
it would be great to make it flexible, e.g. allow using S3, or change namespace or bucket names.
i suggest making it configurable, i can do such PR if we agree its needed.
The text was updated successfully, but these errors were encountered: