Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): drop Python 3.7 for kfp sdk #10750

Merged
merged 29 commits into from
May 3, 2024
Merged

chore(sdk): drop Python 3.7 for kfp sdk #10750

merged 29 commits into from
May 3, 2024

Conversation

rickyxie0929
Copy link
Contributor

@rickyxie0929 rickyxie0929 commented Apr 25, 2024 •
edited
Loading

Description of your changes:
chore(sdk): drop Python 3.7 for kfp sdk

Checklist:

rickyxie0929 and others added 12 commits April 23, 2024 16:23
@rickyxie0929
chore(components): Drop GCPC Python 3.7
0a93e1a 
PiperOrigin-RevId: 627500444

**Description of your changes:**

**Checklist:**
- [ ] The title for your pull request (PR) should follow our title convention. [Learn more about the pull request title convention used in this repository](https://github.com/kubeflow/pipelines/blob/master/CONTRIBUTING.md#pull-request-title-convention).
<!--
   PR titles examples:
    * `fix(frontend): fixes empty page. Fixes kubeflow#1234`
       Use `fix` to indicate that this PR fixes a bug.
    * `feat(backend): configurable service account. Fixes kubeflow#1234, fixes kubeflow#1235`
       Use `feat` to indicate that this PR adds a new feature.
    * `chore: set up changelog generation tools`
       Use `chore` to indicate that this PR makes some changes that users don't need to know.
    * `test: fix CI failure. Part of kubeflow#1234`
        Use `part of` to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
-->
@rickyxie0929
drop support python3.7
0dcc480
@rickyxie0929
fix test
cb5ac53 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
fix test
0fa3562 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
fix test
7b986e2 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
fix test
dd0b55a 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
fix tes
2c524d5 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
fix test
15c066b 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
fix test
19b1528 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
Merge branch 'kubeflow:master' into python
0481ff3
@rickyxie0929
remove kfp related
60bd20f 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
remove kfp related
97cd571 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
just kfp change
11e79d2 
Signed-off-by: rickyxie0929 <[email protected]>
connor-mccarthy
connor-mccarthy requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title of this PR is out-of-date since the changes are for the KFP SDK rather than GCPC SDK. Can we also use the Pull Request Title Convention?

sdk/python/kfp/__init__.py Outdated Show resolved Hide resolved
sdk/python/kfp/__init__.py Show resolved Hide resolved
@rickyxie0929 rickyxie0929 marked this pull request as draft April 25, 2024 17:31
@rickyxie0929
change
41bb5a3 
Signed-off-by: rickyxie0929 <[email protected]>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 25, 2024
@rickyxie0929
change
926353e 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
Copy link
Contributor Author

/retest

@rickyxie0929
Copy link
Contributor Author

/retest-required

@rickyxie0929
Copy link
Contributor Author

/restest

@rickyxie0929
Copy link
Contributor Author

/test kubeflow-pipelines-sdk-execution-tests

@rickyxie0929
Update base image
849b1ea 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
change test python 3.7 to python 3.8
e114d3e 
Signed-off-by: rickyxie0929 <[email protected]>
@rickyxie0929
update golden snapshot
d399aa0 
Signed-off-by: rickyxie0929 <[email protected]>
@google-oss-prow google-oss-prow bot added size/XL and removed size/S labels May 2, 2024
chensun
chensun reviewed May 2, 2024
View reviewed changes
sdk/RELEASE.md Outdated Show resolved Hide resolved
@rickyxie0929
Update Readme
0da6c6d 
Signed-off-by: rickyxie0929 <[email protected]>
connor-mccarthy
connor-mccarthy requested changes May 2, 2024
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is part 2 of this PR? I see the title says "(part 1)".

kubernetes_platform/python/test/snapshot/data/config_map_as_env.yaml
@@ -32,7 +32,7 @@ deploymentSpec:
'
- "\nimport kfp\nfrom kfp import dsl\nfrom kfp.dsl import *\nfrom typing import\
\ *\n\ndef comp():\n pass\n\n"
image: python:3.7
image: python:3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the files under kubernetes_platform/ are for kfp-kubernetes. Should we do that in a separate change?

sdk/python/test_data/pipelines/two_step_pipeline.yaml
@@ -88,4 +88,4 @@ root:
isOptional: true
parameterType: STRING
schemaVersion: 2.1.0
sdkVersion: kfp-2.0.0-rc.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these changes aren't strictly necessary since they don't affect the Python version. We can leave them but FYI.

@rickyxie0929 rickyxie0929 changed the title chore(sdk): drop Python 3.7 for kfp sdk(part 1) chore(sdk): drop Python 3.7 for kfp sdk May 2, 2024
connor-mccarthy
connor-mccarthy requested changes May 2, 2024
View reviewed changes
sdk/RELEASE.md Outdated Show resolved Hide resolved
@rickyxie0929
Update readme
20ab4d8 
Signed-off-by: rickyxie0929 <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

@rickyxie0929: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-test-python37 926353e link true /test kfp-kubernetes-test-python37
kubeflow-pipelines-sdk-python37 926353e link true /test kubeflow-pipelines-sdk-python37
test-kfp-runtime-code-python37 926353e link true /test test-kfp-runtime-code-python37
kubeflow-pipeline-e2e-test 20ab4d8 link true /test kubeflow-pipeline-e2e-test
kfp-kubernetes-execution-tests 20ab4d8 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chensun
chensun approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label May 3, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rickyxie0929
Copy link
Contributor Author

/retest-required

@google-oss-prow google-oss-prow bot merged commit 2f3dd3d into kubeflow:master May 3, 2024
25 of 27 checks passed
@PChambino PChambino mentioned this pull request May 15, 2024
Merged
1 task
@gmfrasca gmfrasca mentioned this pull request May 16, 2024
Merged
@juliusvonkohout juliusvonkohout mentioned this pull request Jun 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@connor-mccarthy connor-mccarthy Awaiting requested review from connor-mccarthy

Assignees

@chensun chensun

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickyxie0929 @chensun @connor-mccarthy