Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DSL should not hardcode the Minio endpoint in the Kubernetes cluster. #362

Closed
gaoning777 opened this issue Nov 21, 2018 · 3 comments · Fixed by #1297
Closed

The DSL should not hardcode the Minio endpoint in the Kubernetes cluster. #362

gaoning777 opened this issue Nov 21, 2018 · 3 comments · Fixed by #1297
Assignees
@gaoning777
Labels
area/backend area/sdk/dsl kind/bug priority/p2

Comments

@gaoning777
Copy link
Contributor

Currently DSL hardcode the namespace of minio service to default. This would break when pipeline is deployed to another ns.
If possible, we should probably use the default argo repository to avoid DSL involvement.
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 21, 2018

we should probably use the default argo repository

+1 Unfortunately using artifact key currently requires you to specify everything.
The best solution would be to add this missing information in the backend before starting the pipeline. The secrets should not be embedded in the pipeline.

@Ark-kun Ark-kun mentioned this issue Nov 21, 2018
Closed
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 25, 2018 •
edited
Loading

Parameterize artifact namespace in DSL

I think it's better for this setting to be configured on the pipeline level, not in DSL.

@vicaire vicaire assigned gaoning777 and unassigned gaoning777, qimingj and IronPan Mar 26, 2019
@vicaire vicaire changed the title Parameterize artifact namespace in DSL The DSL should not hardcode the Minio endpoint in the Kubernetes cluster. Mar 26, 2019
@Ark-kun Ark-kun mentioned this issue Apr 26, 2019
Closed
@Ark-kun Ark-kun mentioned this issue Jun 1, 2019
Merged
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 1, 2019

Fixed by #1297

@Ark-kun Ark-kun closed this as completed Jun 1, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@xaniasd @k8s-ci-robot
make connection to minio configurable (kubeflow#362)
388f162 
* make connection to minio configurable

* use correct environment variables

* add missing import
make linter happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaoning777 gaoning777

Labels
area/backend area/sdk/dsl kind/bug priority/p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SDK - Stopped hard-coding artifact storage configuration in the pipeline packages Ark-kun/pipelines
5 participants
@Ark-kun @IronPan @gaoning777 @qimingj @vicaire