Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different bots for test and release jobs #272

Closed
adrcunha opened this issue Nov 21, 2018 · 1 comment
Closed

Use different bots for test and release jobs #272

adrcunha opened this issue Nov 21, 2018 · 1 comment
Assignees
@adrcunha

Comments

@adrcunha
Copy link
Contributor

This way test jobs can't harm release properties (e.g., GCR).
@adrcunha adrcunha self-assigned this Dec 5, 2018
@adrcunha
Copy link
Contributor Author

#303 splits test and nightly jobs between different service accounts.

@adrcunha adrcunha mentioned this issue Dec 14, 2018
Merged
knative-prow-robot pushed a commit that referenced this issue Dec 17, 2018
@adrcunha @knative-prow-robot
Enable weekly "dot" releases for Knative Serving (#321)
3a68f10 
Fixes #272.
Fixes knative/serving#2427.

Bonus: update documentation about the right service accounts used in the Boskos projects.
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this issue Jun 13, 2020
@vagababov @knative-prow-robot
Cleanup the webhook code. (knative#272)
dc1adcf 
* Cleanup the webhook code.

- add more tests
- fix formatting
- fix logging and errors
- use shorthands
- some optimizations in types
- make code more Go'ey from C'ey.

* raise test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrcunha adrcunha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrcunha