Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate acccounts for test and release jobs #303

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Use separate acccounts for test and release jobs #303

merged 1 commit into from
Dec 10, 2018

Conversation

adrcunha
Copy link
Contributor

@adrcunha adrcunha commented Dec 8, 2018

  • knative-tests is used for test jobs
  • knative-nightly is used for nightly release jobs

The presets and secrets were renamed appropriately for clarity.

* _knative-tests_ is used for test jobs
* _knative-nightly_ is used for nightly release jobs

The presets and secrets were renamed appropriately for clarity.
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2018
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 8, 2018
@srinivashegde86
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2018
@knative-prow-robot knative-prow-robot merged commit bb298fe into knative:master Dec 10, 2018
@adrcunha adrcunha deleted the rename-secret branch December 10, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants