Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventing.* resources v1 umbrella task #3411

Closed
aliok opened this issue Jun 25, 2020 · 8 comments
Closed

eventing.* resources v1 umbrella task #3411

aliok opened this issue Jun 25, 2020 · 8 comments
Labels
area/api kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@aliok
Copy link
Member

aliok commented Jun 25, 2020

Based on a discussion here: https://knative.slack.com/archives/C9JP909F0/p1593003339137900

  1. Implement V1 API for eventing.* resources. #3337: Implement V1 API for eventing.* resources.
  2. Add new version to CRD and update the CRD field descriptions (see the chat)
  3. Update docs and examples
  4. Update e2e tests to use v1: Eventing v1 e2e #3430
  5. Make v1 the storage version: Make eventing.* v1 resources the stored version #3579
  6. Migrate reconciler to v1: Make reconcilers use eventing.* v1 resources #3580
  7. Remove v1beta1 (long term goal)
@aliok
Copy link
Member Author

aliok commented Jun 25, 2020

I need your feedback @lionelvillard @vaikas on the order and also the sensibility of the tasks

@lionelvillard
Copy link
Member

I would put 5 before 3, to encourage people to use the v1 ASAP.

Thanks for putting this together!

@aliok
Copy link
Member Author

aliok commented Jun 25, 2020

Ok, let me wait a little more to see if there's any other input and then update the PR desc.
thanks!

@vaikas
Copy link
Contributor

vaikas commented Jun 26, 2020

Yes, reconciler can wait and can happen even after .16. Otherwise, looks good. Guess, move 3 to 6 and 6 to 7.

Thanks!!

@grantr
Copy link
Contributor

grantr commented Jun 29, 2020

This issue only applies to the eventing.knative.dev group, right? So we probably need more issues for messaging and flows.

@grantr grantr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 29, 2020
@grantr
Copy link
Contributor

grantr commented Jun 29, 2020

1-4 need to be done for 0.16.0. The others can happen in later releases.

@aliok
Copy link
Member Author

aliok commented Aug 25, 2020

/close

These are all done, except removing the v1beta1 resources.
I think we will do the removal in a batch, no need to keep this ticket open.

@knative-prow-robot
Copy link
Contributor

@aliok: Closing this issue.

In response to this:

/close

These are all done, except removing the v1beta1 resources.
I think we will do the removal in a batch, no need to keep this ticket open.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants