Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trigger openapi #3436

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix trigger openapi #3436

merged 1 commit into from
Jun 30, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jun 29, 2020

Addresses #3411

Proposed Changes

  • openapi schema matches reality

Release Note

Docs

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 29, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
n3wscott
n3wscott reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor Author

vaikas commented Jun 29, 2020

Failed with this:

Error from server (InternalError): error when creating "https://github.com/knative/eventing/releases/download/v0.15.2/eventing.yaml": Internal error occurred: failed calling webhook "config.webhook.eventing.knative.dev": Post https://eventing-webhook.knative-eventing.svc:443/config-validation?timeout=2s: no endpoints available for service "eventing-webhook"

@matzew
Copy link
Member

matzew commented Jun 30, 2020

/test pull-knative-eventing-upgrade-tests

@matzew
Copy link
Member

matzew commented Jun 30, 2020

@vaikas I could not reproduce this locally, did trigger a /retest 😄

@knative-prow-robot knative-prow-robot merged commit 2c2e2c9 into knative:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@aslom aslom Awaiting requested review from aslom

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaikas @knative-prow-robot @matzew @n3wscott @googlebot