Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement V1 API for messaging.* resources. #3336

Closed
vaikas opened this issue Jun 17, 2020 · 8 comments
Closed

Implement V1 API for messaging.* resources. #3336

vaikas opened this issue Jun 17, 2020 · 8 comments
Assignees
Labels
area/api kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@vaikas
Copy link
Contributor

vaikas commented Jun 17, 2020

Problem
Add V1 api for messaging.*

As discussed today, we'll break the tasks down by the api group. This issue tracks the work for that. Also as discussed in the meeting, I offered to jot down some representative PRs that are necessary for the work, and hopefully will help folks doing the work:
Introduce types:
#2407

Defaulting webhook:
#2645

Conversions:
#2611
(but since the functions were renamed, so need to use these names):
#2632

That's a start, I might be missing something but figured I'd share some resources so folks can get started :)

@vaikas vaikas added this to the v0.16.0 milestone Jun 17, 2020
@nlopezgi
Copy link
Contributor

I'm taking a stab at helping with this one.

@matzew
Copy link
Member

matzew commented Jun 19, 2020

@nlopezgi do you need help, e.g. on doing conversion?

@nlopezgi
Copy link
Contributor

@nlopezgi do you need help, e.g. on doing conversion?

Thanks @matzew , I think I'm pretty close to getting the conversion working correctly, I could not finish it last friday but I should be done with this very soon. Will holler if I need a hand.

@lberk lberk added area/api priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 22, 2020
@nlopezgi
Copy link
Contributor

I think that with #3435 we should be done with this issue? Let me know if something is pending to work on it.

@matzew
Copy link
Member

matzew commented Jun 30, 2020

@nlopezgi I think so too. Do you mind creating an umbrella task like @aliok did #3411 ?

@matzew
Copy link
Member

matzew commented Jun 30, 2020

/close

@knative-prow-robot
Copy link
Contributor

@matzew: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nlopezgi
Copy link
Contributor

@nlopezgi I think so too. Do you mind creating an umbrella task like @aliok did #3411 ?

Created #3446, but I'm not planning on working on this task for the remainder of this week and likely next one. If this is of high priority lets sync to see what's the best strategy to get this landed in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants