Skip to content

Commit

Permalink
[8.x] [Infra] Unskip infra serverless tests (elastic#202146) (elastic…
Browse files Browse the repository at this point in the history 
…#202640)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Infra] Unskip infra serverless tests
(elastic#202146)](elastic#202146)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T17:45:48Z","message":"[Infra]
Unskip infra serverless tests (elastic#202146)\n\nfixes
[191809](https://github.com/elastic/kibana/issues/191809)\r\n\r\n##
Summary\r\n\r\nUnskip infra e2e serverless
tests","sha":"bedc0660d8dab074aa488bccbab662269f7f21df","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"number":202146,"url":"https://github.com/elastic/kibana/pull/202146","mergeCommit":{"message":"[Infra]
Unskip infra serverless tests (elastic#202146)\n\nfixes
[191809](https://github.com/elastic/kibana/issues/191809)\r\n\r\n##
Summary\r\n\r\nUnskip infra e2e serverless
tests","sha":"bedc0660d8dab074aa488bccbab662269f7f21df"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202146","number":202146,"mergeCommit":{"message":"[Infra]
Unskip infra serverless tests (elastic#202146)\n\nfixes
[191809](https://github.com/elastic/kibana/issues/191809)\r\n\r\n##
Summary\r\n\r\nUnskip infra e2e serverless
tests","sha":"bedc0660d8dab074aa488bccbab662269f7f21df"}}]}] BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
  • Loading branch information
@jennypavlova @crespocarlos
jennypavlova and crespocarlos authored Dec 3, 2024
1 parent e8db384 commit edeed14
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 68 deletions.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1183,6 +1183,8 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
/x-pack/plugins/observability_solution/infra/server/services @elastic/obs-ux-infra_services-team
/x-pack/plugins/observability_solution/infra/server/usage @elastic/obs-ux-infra_services-team
/x-pack/plugins/observability_solution/infra/server/utils @elastic/obs-ux-infra_services-team
/x-pack/test_serverless/functional/test_suites/observability/infra @elastic/obs-ux-infra_services-team
/x-pack/test/api_integration/services/infraops_source_configuration.ts @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team # Assigned per https://github.com/elastic/kibana/pull/34916

## Logs UI code exceptions -> @elastic/obs-ux-logs-team
/x-pack/test_serverless/functional/page_objects/svl_oblt_onboarding_stream_log_file.ts @elastic/obs-ux-logs-team
Expand Down
38 changes: 0 additions & 38 deletions x-pack/test_serverless/functional/test_suites/observability/infra/header_menu.ts
View file

This file was deleted.

32 changes: 10 additions & 22 deletions x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,28 +40,22 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
(await pageObjects.infraHostsView.isKPIChartsLoaded())
);

// failing feature flag test, see https://github.com/elastic/kibana/issues/191810
describe.skip('Hosts Page', function () {
describe('Hosts Page', function () {
before(async () => {
await Promise.all([
esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'),
]);
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await pageObjects.svlCommonPage.loginAsViewer();
await browser.setWindowSize(1600, 1200);

await pageObjects.common.navigateToApp(HOSTS_VIEW_PATH);
await pageObjects.header.waitUntilLoadingHasFinished();

await browser.setWindowSize(1600, 1400);
});

after(async () => {
await Promise.all([
esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'),
]);
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
});

describe('#Single Host Flyout', () => {
before(async () => {
await pageObjects.common.navigateToApp(HOSTS_VIEW_PATH);
await pageObjects.header.waitUntilLoadingHasFinished();
});

describe('Tabs', () => {
before(async () => {
await pageObjects.timePicker.setAbsoluteRange(
Expand Down Expand Up @@ -100,10 +94,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('should show alerts', async () => {
await pageObjects.header.waitUntilLoadingHasFinished();
await pageObjects.assetDetails.overviewAlertsTitleExists();
const CreateRuleButtonExist = await testSubjects.exists(
'infraAssetDetailsCreateAlertsRuleButton'
);
expect(CreateRuleButtonExist).to.be(true);
await pageObjects.assetDetails.overviewOpenAlertsFlyoutExist();
});
});

Expand All @@ -123,7 +114,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});

it('should show processes title', async () => {
await await testSubjects.existOrFail('infraAssetDetailsTopProcessesTitle');
await testSubjects.existOrFail('infraAssetDetailsTopProcessesTitle');
});
});

Expand Down Expand Up @@ -175,7 +166,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('Metrics Tab', () => {
before(async () => {
await browser.scrollTop();
await pageObjects.infraHostsView.visitMetricsTab();
});

Expand All @@ -191,7 +181,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('Logs Tab', () => {
before(async () => {
await browser.scrollTop();
await pageObjects.infraHostsView.visitLogsTab();
});

Expand All @@ -206,7 +195,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('Alerts Tab', () => {
before(async () => {
await browser.scrollTop();
await pageObjects.infraHostsView.visitAlertTab();
});

Expand Down
1 change: 0 additions & 1 deletion x-pack/test_serverless/functional/test_suites/observability/infra/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ loadTestFile }: FtrProviderContext) {
describe('Observability Infra', function () {
loadTestFile(require.resolve('./header_menu'));
loadTestFile(require.resolve('./navigation'));
loadTestFile(require.resolve('./node_details'));
loadTestFile(require.resolve('./hosts_page'));
Expand Down
10 changes: 3 additions & 7 deletions x-pack/test_serverless/functional/test_suites/observability/infra/node_details.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
'svlCommonPage',
]);

// failing feature flag test, see https://github.com/elastic/kibana/issues/191809
describe.skip('Node Details', () => {
describe('Node Details', () => {
describe('#With Asset Details', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
Expand All @@ -50,7 +49,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Osquery Tab', () => {
it('should not render in serverless', async () => {
const OsqueryExist = await testSubjects.exists('infraAssetDetailsOsqueryTab');
expect(OsqueryExist).to.be(false);
expect(OsqueryExist).to.be(true);
});
});

Expand All @@ -68,10 +67,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('should show alerts', async () => {
await pageObjects.header.waitUntilLoadingHasFinished();
await pageObjects.assetDetails.overviewAlertsTitleExists();
const CreateRuleButtonExist = await testSubjects.exists(
'infraAssetDetailsCreateAlertsRuleButton'
);
expect(CreateRuleButtonExist).to.be(true);
await pageObjects.assetDetails.overviewOpenAlertsFlyoutExist();
});

[
Expand Down

0 comments on commit edeed14

Please sign in to comment.