Skip to content

Commit

Permalink
[8.x] [TSVB] fix point visibility regression (elastic#202358) (elasti…
Browse files Browse the repository at this point in the history
…c#202639)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[TSVB] fix point visibility regression
(elastic#202358)](elastic#202358)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB]
fix point visibility regression (elastic#202358)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression
was caused by a
[breaking\r\nchange](elastic/elastic-charts#2525)
introduced\r\nby elastic-charts around the `area.points.visible` style,
that passed\r\nfrom a `boolean` to a union of `'always' | 'never' |
'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB]
fix point visibility
regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB]
fix point visibility regression (elastic#202358)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression
was caused by a
[breaking\r\nchange](elastic/elastic-charts#2525)
introduced\r\nby elastic-charts around the `area.points.visible` style,
that passed\r\nfrom a `boolean` to a union of `'always' | 'never' |
'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB]
fix point visibility regression (elastic#202358)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression
was caused by a
[breaking\r\nchange](elastic/elastic-charts#2525)
introduced\r\nby elastic-charts around the `area.points.visible` style,
that passed\r\nfrom a `boolean` to a union of `'always' | 'never' |
'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>
  • Loading branch information
kibanamachine and markov00 authored Dec 3, 2024
1 parent 5d73f2f commit e8db384
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const getAreaStyles = ({ points, lines, color }) => ({
radius: points.radius || 0.5,
stroke: color || DEFAULT_COLOR,
strokeWidth: points.lineWidth || 5,
visible: points.lineWidth > 0 && Boolean(points.show),
visible: points.lineWidth > 0 && Boolean(points.show) ? 'always' : 'never',
},
},
curve: lines.steps ? CurveType.CURVE_STEP_AFTER : CurveType.LINEAR,
Expand Down

0 comments on commit e8db384

Please sign in to comment.