Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Unskip infra serverless tests #202146

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Nov 28, 2024

fixes 191809

Summary

Unskip infra e2e serverless tests

@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 28, 2024
@crespocarlos
Copy link
Contributor Author

/ci

@@ -1,38 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't make sense anymore because the alert feature is now enabled on Serverless

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7528

[✅] x-pack/test_serverless/api_integration/test_suites/observability/config.feature_flags.ts: 25/25 tests passed.

see run history

@crespocarlos crespocarlos marked this pull request as ready for review November 28, 2024 12:34
@crespocarlos crespocarlos requested a review from a team as a code owner November 28, 2024 12:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Does it make sense to change the code owner from Observability UI to Infra team?

@crespocarlos crespocarlos enabled auto-merge (squash) November 29, 2024 16:20
@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit bedc066 into elastic:main Nov 29, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12088857283

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #112 / Exception list APIs Authentication - Complete Tier @serverless @serverlessQA viewer exception list API behaviors find exception list should return 200 for viewer

Metrics [docs]

✅ unchanged

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Streams] App plugin (#200060)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202146

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 2, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202146 locally

@jennypavlova
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Dec 3, 2024
fixes [191809](elastic#191809)

## Summary

Unskip infra e2e serverless tests

(cherry picked from commit bedc066)

# Conflicts:
#	.github/CODEOWNERS
jennypavlova added a commit that referenced this pull request Dec 3, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Infra] Unskip infra serverless tests
(#202146)](#202146)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T17:45:48Z","message":"[Infra]
Unskip infra serverless tests (#202146)\n\nfixes
[191809](https://github.com/elastic/kibana/issues/191809)\r\n\r\n##
Summary\r\n\r\nUnskip infra e2e serverless
tests","sha":"bedc0660d8dab074aa488bccbab662269f7f21df","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"number":202146,"url":"https://github.com/elastic/kibana/pull/202146","mergeCommit":{"message":"[Infra]
Unskip infra serverless tests (#202146)\n\nfixes
[191809](https://github.com/elastic/kibana/issues/191809)\r\n\r\n##
Summary\r\n\r\nUnskip infra e2e serverless
tests","sha":"bedc0660d8dab074aa488bccbab662269f7f21df"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202146","number":202146,"mergeCommit":{"message":"[Infra]
Unskip infra serverless tests (#202146)\n\nfixes
[191809](https://github.com/elastic/kibana/issues/191809)\r\n\r\n##
Summary\r\n\r\nUnskip infra e2e serverless
tests","sha":"bedc0660d8dab074aa488bccbab662269f7f21df"}}]}] BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 3, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
fixes [191809](elastic#191809)

## Summary

Unskip infra e2e serverless tests
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
fixes [191809](elastic#191809)

## Summary

Unskip infra e2e serverless tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
5 participants