Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add step and aggregation fields for kubectl get KeptnMetric #2556

Merged
merged 10 commits into from
Jan 17, 2024

Conversation

AryanSharma9917
Copy link
Contributor

This PR closes : #2100

Signed-off-by: aryansharma9917 <[email protected]>
@AryanSharma9917 AryanSharma9917 requested a review from a team as a code owner November 23, 2023 12:34
@odubajDT odubajDT changed the title Added step and aggregation fields for kubectl get KeptnMetric feat: add step and aggregation fields for kubectl get KeptnMetric Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16e1f86) 85.68% compared to head (d24265a) 85.75%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
+ Coverage   85.68%   85.75%   +0.06%     
==========================================
  Files         160      160              
  Lines       10164    10164              
==========================================
+ Hits         8709     8716       +7     
+ Misses       1174     1169       -5     
+ Partials      281      279       -2     
Files Coverage Δ
metrics-operator/api/v1beta1/keptnmetric_types.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 57.12% <ø> (+1.03%) ⬆️
lifecycle-operator 84.72% <ø> (ø)
metrics-operator 87.65% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit f8a6f17
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6573630b94e241000720d5bb
😎 Deploy Preview https://deploy-preview-2556--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prakrit55
Copy link
Member

After these lines you put your texts that you have added, with properly aligned.



@odubajDT
Copy link
Contributor

Hi @AryanSharma9917 do you have the capacity to finish this PR? Thanks!

Signed-off-by: aryansharma9917 <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
AryanSharma9917 and others added 2 commits December 7, 2023 00:15
@odubajDT
Copy link
Contributor

odubajDT commented Dec 7, 2023

can you also adapt this file please? .github/scripts/.helm-tests/metrics-only-with-apiservice-disabled/result.yaml

@github-actions github-actions bot added the ops label Dec 8, 2023
Signed-off-by: Aryan Sharma <[email protected]>
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AryanSharma9917
Copy link
Contributor Author

can you also adapt this file please? .github/scripts/.helm-tests/metrics-only-with-apiservice-disabled/result.yaml

Done..!!

@odubajDT
Copy link
Contributor

can you also adapt this file please? .github/scripts/.helm-tests/metrics-only-with-apiservice-disabled/result.yaml

Done..!!

The fields were added in a wrong place, can you please adapt it?

--- ./.github/scripts/.helm-tests/metrics-only-with-apiservice-disabled/helm_tests_output.yaml	2023-12-11 06:32:30.315336491 +0000
+++ ./.github/scripts/.helm-tests/metrics-only-with-apiservice-disabled/result.yaml	2023-12-11 06:32:25.895373723 +0000
@@ -1397,15 +1397,15 @@
     - jsonPath: .spec.range.interval
       name: Interval
       type: string
+    - jsonPath: .status.value
+      name: Value
+      type: string
     - jsonPath: .spec.range.step
       name: Step
       type: string
     - jsonPath: .spec.range.aggregation
       name: Aggregation
       type: string
-    - jsonPath: .status.value
-      name: Value
-      type: string
     name: v1alpha3
     schema:
       openAPIV3Schema:

@rakshitgondwal
Copy link
Member

Hi @AryanSharma9917, are you still working on this?

@odubajDT
Copy link
Contributor

Hi @AryanSharma9917 any updates here ?

@odubajDT
Copy link
Contributor

Since there was no response from Dec 8th, I am taking overt this PR.

Signed-off-by: odubajDT <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

15.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@odubajDT odubajDT merged commit abe00fc into keptn:main Jan 17, 2024
41 of 42 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…c` (keptn#2556)

Signed-off-by: aryansharma9917 <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]>
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add step and aggregation fields for kubectl get KeptnMetric
6 participants