-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add step
and aggregation
fields for kubectl get KeptnMetric
#2556
Conversation
Signed-off-by: aryansharma9917 <[email protected]>
step
and aggregation
fields for kubectl get KeptnMetric
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
==========================================
+ Coverage 85.68% 85.75% +0.06%
==========================================
Files 160 160
Lines 10164 10164
==========================================
+ Hits 8709 8716 +7
+ Misses 1174 1169 -5
+ Partials 281 279 -2
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
After these lines you put your texts that you have added, with properly aligned.
|
Hi @AryanSharma9917 do you have the capacity to finish this PR? Thanks! |
Signed-off-by: aryansharma9917 <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Aryan Sharma <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Aryan Sharma <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Aryan Sharma <[email protected]>
can you also adapt this file please? |
Signed-off-by: Aryan Sharma <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Done..!! |
The fields were added in a wrong place, can you please adapt it?
|
Hi @AryanSharma9917, are you still working on this? |
Hi @AryanSharma9917 any updates here ? |
Since there was no response from Dec 8th, I am taking overt this PR. |
Signed-off-by: odubajDT <[email protected]>
Quality Gate failedFailed conditions 15.7% Duplication on New Code (required ≤ 3%) |
…c` (keptn#2556) Signed-off-by: aryansharma9917 <[email protected]> Signed-off-by: Aryan Sharma <[email protected]> Signed-off-by: odubajDT <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Co-authored-by: Florian Bacher <[email protected]> Co-authored-by: Rakshit Gondwal <[email protected]> Co-authored-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
This PR closes : #2100