Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step and aggregation fields for kubectl get KeptnMetric #2100

Closed
rakshitgondwal opened this issue Sep 14, 2023 · 7 comments · Fixed by #2556
Closed

Add step and aggregation fields for kubectl get KeptnMetric #2100

rakshitgondwal opened this issue Sep 14, 2023 · 7 comments · Fixed by #2556
Labels
good first issue Good for newcomers

Comments

@rakshitgondwal
Copy link
Member

It is now possible to have a metric.spec.range.step and metric.spec.range.aggregation field defined in a KeptnMetric.

It would be a nice idea to have step and aggregation fields for kubectl get KeptnMetric too.

  • The value of step shoud be range.step.
  • The value of aggregation should be range.aggregation

Screenshot from 2023-09-14 16-19-53
@rakshitgondwal rakshitgondwal added the status: ready-for-refinement Issue is relevant for the next backlog refinment label Sep 14, 2023
@AryanSharma9917
Copy link
Contributor

Hi @rakshitgondwal, can I work on this issue?

@RealAnna RealAnna added good first issue Good for newcomers and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Sep 20, 2023
@RealAnna RealAnna assigned RealAnna and AryanSharma9917 and unassigned RealAnna Sep 20, 2023
@rakshitgondwal
Copy link
Member Author

@AryanSharma9917 You can have a look at this PR which resembles what need's to be done in this issue #1689

@AryanSharma9917 AryanSharma9917 mentioned this issue Sep 20, 2023
Closed
@github-actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
@mowies mowies reopened this Nov 21, 2023
@AryanSharma9917 AryanSharma9917 mentioned this issue Nov 23, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@mowies mowies moved this from ✅ Done to 🏃 In progress in Keptn Lifecycle Toolkit Dec 18, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@github-project-automation github-project-automation bot moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Jan 17, 2024
@mowies mowies reopened this Jan 17, 2024
@mowies
Copy link
Member

mowies commented Jan 17, 2024

Unassigned, since there were no updates from the contributor. Somebody else can take over the almost finished PR and bring it over the line.

@mowies mowies moved this from ✅ Done to 🎟️ Refined in Keptn Lifecycle Toolkit Jan 17, 2024
@github-project-automation github-project-automation bot moved this from 🎟️ Refined to ✅ Done in Keptn Lifecycle Toolkit Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
4 participants
@mowies @AryanSharma9917 @RealAnna @rakshitgondwal