-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add step
and aggregation
fields for kubectl get KeptnMetric
#2142
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
You need to sign off your commits @AryanSharma9917 |
step
and aggregation
fields for kubectl get KeptnMetric
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2142 +/- ##
==========================================
+ Coverage 84.34% 84.51% +0.16%
==========================================
Files 151 154 +3
Lines 9601 9918 +317
==========================================
+ Hits 8098 8382 +284
- Misses 1218 1249 +31
- Partials 285 287 +2
... and 32 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: aryansharma9917 <[email protected]>
7997ada
to
dabb582
Compare
Hi @rakshitgondwal, I have signed off my commit could you please review my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested out the changes, and everything LGTM.
Thank you for your contribution @AryanSharma9917
Thank you for your contribution! Can you also please update the CRD in our helm charts? Currently we need to update them manually https://github.com/keptn/lifecycle-toolkit/blob/main/helm/chart/templates/keptnmetric-crd.yaml#L191 Thank you! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please adapt the helm test results as well, execute:
from the root folder Also please sign off your commits |
Hello @AryanSharma9917 can you please resolve the conflicts against main branch ? Thank you! |
Hey @AryanSharma9917, are you still working on this? |
Yes @rakshitgondwal, I'll solve the issue ASAP..! |
Hey @AryanSharma9917, any updates on this? if you are facing any issues let me know. |
Hey @AryanSharma9917 any updates on this PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AryanSharma9917 we moved the metrics API to v1beta1. It should be pretty easy to just move your changes over to the beta files. Then this PR can be merged!
Hi @mowies , @rakshitgondwal I have made the updated changes in this new PR could you please give it a look. |
Closing in favor of #2556 |
This PR closes : #2100