Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add interval field for kubectl get KeptnMetric #1689

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: add interval field for kubectl get KeptnMetric #1689

merged 1 commit into from
Jul 10, 2023

Conversation

rakshitgondwal
Copy link
Member

Fixes #1677

Changes made:

  • Introduced a new interval field for kubectl get KeptnMetric.
  • This field has the value of metric.spec.range.interval field.

Some screenshots:

  • With range.interval field defined

    Screenshot from 2023-07-06 20-04-01

  • Without a range.interval field defined

    Screenshot from 2023-07-06 20-05-08

@rakshitgondwal rakshitgondwal requested a review from a team as a code owner July 6, 2023 14:42
@netlify
Copy link

netlify bot commented Jul 6, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 4b18464
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a6d2c7b061c90008be6a14
😎 Deploy Preview https://deploy-preview-1689--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #1689 (4b18464) into main (78ba574) will decrease coverage by 1.92%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
- Coverage   63.47%   61.56%   -1.92%     
==========================================
  Files         142      118      -24     
  Lines       10899     9946     -953     
==========================================
- Hits         6918     6123     -795     
+ Misses       3719     3599     -120     
+ Partials      262      224      -38

see 40 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.27% <ø> (ø)
lifecycle-operator 84.50% <ø> (+0.01%) ⬆️
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

StackScribe
StackScribe reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require an update to https://main.lifecycle.keptn.sh/docs/yaml-crd-ref/metric/ and possibly other files listed in the "See also" for that page? Just curious -- it doesn't need to be in the same PR.

@rakshitgondwal
Copy link
Member Author

Yes, it does require changes to the documentation. @StackScribe.
I was thinking to make changes to the documentation once the PRs to update metric provider's APIs get merged.

thisthat
thisthat approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@thisthat thisthat merged commit 1599ee9 into keptn:main Jul 10, 2023
@keptn-bot keptn-bot mentioned this pull request Jul 10, 2023
Merged
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
@rakshitgondwal @Nitishupkr
feat: add interval field for kubectl get KeptnMetric (keptn#1689)
3828f1b 
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Nitishupkr <[email protected]>
@keptn-bot keptn-bot mentioned this pull request Aug 3, 2023
Closed
@keptn-bot keptn-bot mentioned this pull request Sep 5, 2023
Merged
@rakshitgondwal rakshitgondwal mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@RealAnna RealAnna RealAnna approved these changes

@thisthat thisthat thisthat approved these changes

Assignees
No one assigned
Labels
metrics-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce interval field for kubectl get KeptnMetric
4 participants
@rakshitgondwal @thisthat @StackScribe @RealAnna