-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reference page for KeptnTaskDefinition #1083
Conversation
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. If you really want to move the auto generated API reference, you also need to adjust all other occurrences of that path in all other files in the project.
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
…kit into 0321-task-ref Signed-off-by: Meg McRoberts [email protected] Signed-off-by: Meg McRoberts <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
===========================================
+ Coverage 58.88% 79.53% +20.65%
===========================================
Files 126 119 -7
Lines 10003 7452 -2551
===========================================
+ Hits 5890 5927 +37
+ Misses 3894 1309 -2585
+ Partials 219 216 -3
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is superceeded by #1194 , which just modifies doc content/structure and leaves the auto-generated files in the crd-ref directory rather than attempting to move them to the api-directory. |
Part of #1078 .
This sets up the crd-ref directory and provides a draft of the KeptnTaskDefinition page. This is largely for discussion and PoC although I think this is the beginning of a page that should be completed. It currently has a bit of information I made up and some embedded questions that need to be either answered or removed.
The "CRD Reference Section" title may not be what we want. We discussed having this under Concepts but, with the existing "Concepts" section, this gets messy. So I created this section to be new; we can eventually rename it, although I think having it identified as a Reference section is a good thing.
Note that this PR does not add links from the API Reference pages to these pages. I will do those in a separate PR.