-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reference page for KeptnTaskDefinition #1194
Conversation
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…e-toolkit into 0406-taskdefinition Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
- Coverage 59.76% 59.35% -0.42%
==========================================
Files 138 137 -1
Lines 10444 10267 -177
==========================================
- Hits 6242 6094 -148
+ Misses 3967 3948 -19
+ Partials 235 225 -10 see 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Meg McRoberts <[email protected]>
…e-toolkit into 0406-taskdefinition Signed-off-by: Meg McRoberts [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR has changes in far more files than the task definition. i think those changes don't belong in this PR but in #1224 right?
About all those files that don't belong in the PR... Between rebases and markdownlint -fix, files got pulled in here that don't belong. I think the same files are in PR1224 -- I have no idea how things got so messed up! |
Signed-off-by: Meg McRoberts <[email protected]>
…e-toolkit into 0406-taskdefinition Signed-off-by: Meg McRoberts [email protected]
@StackScribe please either revert the changes that don't belong here via git or manually by copying over the original content |
Signed-off-by: Meg McRoberts <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
This PR is corrupted and so I am deleting it. It is replaced by #1392 . |
This PR moves existing information about tasks into the new structure. Additional work is required for all this material but this is a first step. Specifics:
KeptnTaskDefinition
ref pageKeptnTaskDefinition
ref pageKeptnTaskDefinition
ref page also has some info about parameters and secrets. I think all the "secrets" information needs to be pulled into its own page in the "Implementing..." sectionThis PR supercedes #1083, which also attempted to move the autogenerated files from the crd-ref directory to api-ref.