Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reference page for KeptnTaskDefinition #1083
docs: reference page for KeptnTaskDefinition #1083
Changes from 13 commits
e089a5d
3246ac6
4c4ef1d
84bc148
9937c95
3350da4
35b6026
d7ee06f
7558599
3623ee1
74d49ed
b97cc28
9f93537
8894aca
71b5eea
f2e4b50
4ba83f5
d3e58ce
45be10d
94d01e2
7f2a183
9c3ff2e
bcceba7
cc81eda
ae06ae0
3b108db
5203666
48b2e44
83171e7
fbdfa72
47ad95b
f79b16a
c09b380
beb7d5b
570dc7a
0333070
507c89f
60d67f9
8ee834d
5f77bf6
ee060e2
3ee14f6
91dac8e
761d3da
9c57488
0d1316c
8d25ac7
b62c1d0
b58f8e3
0b61c87
990b6a4
d0c450b
cdce62a
3b496ab
71e6300
1619de9
6f6cc7c
9cbcdc1
bb50730
203d14e
08e831b
3143757
f74171e
0f0e86d
ef27b42
5c3828d
716ed9a
906c9a4
6f6e542
1ef6bcb
9074553
95475a7
f60b150
a993edb
b5c75ad
5b91097
c8d1daf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence doesn't really make sense...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be moved into the secure parameters section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving it where it is for now but think we may want to move this into a guide chapter rather than having it on the reference page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean this doesn't belong to the parameters section in the YAML but to the secureParameters, so this paragraph should also be under the secure parameters headline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add an x-ref here to the relevant k8s docs page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the content of the context variable is defined by us, we should also include that in the reference above.
Especially, what data the user actually has available in the context.