Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v9.0.0 #1864

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Release v9.0.0 #1864

merged 9 commits into from
Apr 17, 2024

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Apr 16, 2024

Description

Release 9.0.0

Major features and improvements

Bug fixes and other changes

Community contributions

Many thanks to the following Kedroids for contributing PR to this release:

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Jitendra Gundaniya <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Isn't there a place to acknowledge community contributors in the changelog, like we do in other plugins? In this case I think I only saw #1809

@jitu5
Copy link
Contributor Author

jitu5 commented Apr 16, 2024

🚀

Isn't there a place to acknowledge community contributors in the changelog, like we do in other plugins? In this case I think I only saw #1809

@astrojuanlu Sure I can section like this
Screenshot 2024-04-16 at 3 57 22 p m

But can we say "Kedroids" for viz also 😀

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Co-authored-by: rashidakanchwala <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
@@ -5,7 +5,7 @@ Please follow the established format:
- Use present tense (e.g. 'Add new feature')
- Include the ID number for the related PR (or PRs) in parentheses
-->
# Upcoming Release
# Release 9.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to Node 18 (#1848) not #1811

Copy link
Contributor

@rashidakanchwala rashidakanchwala Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and 'Add support for JSONDatast preview' should be moved to major features and improvements, i think

Copy link
Contributor

@rashidakanchwala rashidakanchwala Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add #1819, #1798 in 'Bug Fixes and Other Changes'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, Let me add that.

Signed-off-by: Jitendra Gundaniya <[email protected]>
Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , thanks @jitu5 😄
I've tested it locally and everything seems to work as expected to me

Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Let's do it

@jitu5 jitu5 merged commit 4eeae35 into main Apr 17, 2024
14 checks passed
@jitu5 jitu5 deleted the release/9.0.0 branch April 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants