-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dataset Factory Patterns to Experiment Tracking #1824
Conversation
Signed-off-by: ravi-kumar-pilla <[email protected]>
CircleCI Build fix - #1819 |
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Hi @iamelijahko , I know you are working on refactoring catalog api. I wanted to bring this to your notice if this helps - At this moment we are using a private method of DataCatalog to get around resolving the dataset factory patterns in one of our use-case. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Resolves #1689
Development notes
catalog._get_dataset(dataset_name, suggest=False)
to discover patterns before setting catalogNOTE:
Earlier we used
catalog.exists()
on the datasets for discovery which caused the below issues -exists()
also calls _get_dataset internally and also calls AbstractDataset.exists. We are removing this additional callExample patterns -
QA notes
kedro run
, you should see the factory pattern datasets in the experiment tracking runChecklist
RELEASE.md
file