Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 18 #1848

Merged
merged 19 commits into from
Apr 15, 2024
Merged

Upgrade to Node 18 #1848

merged 19 commits into from
Apr 15, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Apr 8, 2024

Description

Fixes #1811

This ticket is to update node from version 16 (which has reached its end-of-life date) to version 18 (which has entered the long-term support)

Development notes

In order to get the app working with node 18, we also updated the following packages to new versions

  • react-script: 5.0.1
  • css-loader: 6.4.0
  • postcss-loader: 8.1.1
  • sass-loader: 14.1.1
  • workerize-loader: 2.0.2
  • webpack: 5.91.0

QA notes

Steps to follow to test:

  1. remove package-lock.json, and node-modules
  2. run npm install
  3. run make build then make run and make sure the app is building properly

Observation while testing it locally
It feels like the stateful URL are not working as expected since I updated Node 18 and react-script. Occasionally, clicking on a node fails to highlight it, or accessing it through the URL doesn't work as intended. Let me know if you see the same

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

gitpod link: https://gitpod.io/new/#github.com/kedro-org/kedro-viz/pull/1848

@Huongg Huongg self-assigned this Apr 8, 2024
@Huongg Huongg marked this pull request as ready for review April 9, 2024 09:48
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need updates here:

_*Note*: We suggest using the [latest release of Node.js v16](https://nodejs.org/download/release/latest-v16.x/) in your development environment._

(and unsure if anything else as per #1764)

@rashidakanchwala rashidakanchwala changed the title Feature/upgrade node Upgrade to Node 18 Apr 11, 2024
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left few comments but nothing is a blocking change. I have tested shareableviz/build on all cloud platforms supported and basic functionality, works well for me. Awesome work Huongg !! Thank you

"prettier": "^2.3.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-error-overlay": "^6.0.9",
"react-scripts": "^4.0.3",
"react-scripts": "^5.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessssss this fixes #1278

Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Huong !!!

@rashidakanchwala
Copy link
Contributor

Amazing work!!!!!!!!. I couldn't test it with cloud. But kedro viz build, also tested with a new starter project using kedro new and it worked fine :) ...

@Huongg Huongg merged commit 21c54f5 into main Apr 15, 2024
14 checks passed
@Huongg Huongg deleted the feature/upgrade-node branch April 15, 2024 13:21
@rashidakanchwala rashidakanchwala mentioned this pull request Apr 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 18
6 participants