-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node 18 #1848
Upgrade to Node 18 #1848
Conversation
Signed-off-by: huongg <[email protected]>
…st version Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
…grade-node Signed-off-by: huongg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nd your node server don't know who to handle it. Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left few comments but nothing is a blocking change. I have tested shareableviz/build on all cloud platforms supported and basic functionality, works well for me. Awesome work Huongg !! Thank you
"prettier": "^2.3.1", | ||
"react": "^18.2.0", | ||
"react-dom": "^18.2.0", | ||
"react-error-overlay": "^6.0.9", | ||
"react-scripts": "^4.0.3", | ||
"react-scripts": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yessssss this fixes #1278
Signed-off-by: huongg <[email protected]>
…grade-node Signed-off-by: huongg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Huong !!!
Amazing work!!!!!!!!. I couldn't test it with cloud. But |
…grade-node Signed-off-by: huongg <[email protected]>
Description
Fixes #1811
This ticket is to update node from version 16 (which has reached its end-of-life date) to version 18 (which has entered the long-term support)
Development notes
In order to get the app working with node 18, we also updated the following packages to new versions
QA notes
Steps to follow to test:
npm install
make build
thenmake run
and make sure the app is building properlyObservation while testing it locally
It feels like the stateful URL are not working as expected since I updated Node 18 and react-script. Occasionally, clicking on a node fails to highlight it, or accessing it through the URL doesn't work as intended. Let me know if you see the same
Checklist
RELEASE.md
filegitpod link: https://gitpod.io/new/#github.com/kedro-org/kedro-viz/pull/1848