-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving rabbitMq host to resolved value #347
Conversation
Actually one thought here that may add consistency and make non-breaking too. Potentially we can add a new property called |
@jeffhollan Given this is still in "alpha"/"beta" and we have the auth changes coming up, I would just consider it as breaking change. We've discussed this as well for the auth changes and would suggest to introduce a versioned image tag which contains the new features for more stable images |
Ok great - yeah let's just do as-is and change how host behaves. @ahmelsayed is going to take a snapshot version of current keda:latest so that people can easily roll back to it as needed if they break from this PR, and the many more around auth spec that will start rolling out |
Thanks @jeffhollan :) |
btw, |
Fixed the date format form `mm:hh:ss` to `hh:mm:ss` Signed-off-by: Nir Geier <[email protected]>
resolve #89
Making a WIP PR as there is a big question on how we release this as it will be breaking.