Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'master' branch in this repo doesn't match 'master' in KEDA repo #2

Closed
eashi opened this issue Oct 26, 2019 · 1 comment
Closed

'master' branch in this repo doesn't match 'master' in KEDA repo #2

eashi opened this issue Oct 26, 2019 · 1 comment

Comments

@eashi
Copy link

eashi commented Oct 26, 2019

The master branch in this repo is synchronized with the KEDA container tagged by latest, which is NOT the master in KEDA repo.

This adds confusion if there is a breaking change in master KEDA, just like the fix #347 for resolving the host from environment.

Should master of this repo synchronise with master in KEDA? Or maybe put a statement at the beginning of README.md that you should check branch x if you are using a KEDA that was built from master.

I feel the release story can be a little better?

@jeffhollan
Copy link
Member

Yep makes sense - some awkwardness for this sample specifically as was impacted by a breaking change before we moved KEDA to 1.0 and started using explicit version tags. That has been cleared up and we have a better release process now. Let me know if any other pending items here.

https://github.com/kedacore/keda/wiki/Release-process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants