Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rabbitmq password to environment. #89

Closed
ahmelsayed opened this issue Apr 18, 2019 · 2 comments · Fixed by #347
Closed

Move rabbitmq password to environment. #89

ahmelsayed opened this issue Apr 18, 2019 · 2 comments · Fixed by #347
Assignees
@jeffhollan
Labels
P1 release-should-have
Milestone
Triaged

Comments

@ahmelsayed
Copy link
Contributor

ahmelsayed commented Apr 18, 2019 •
edited
Loading

I think the current rabbitmq spec contains a password 'guest' https://github.com/Azure/Kore/blob/master/examples/rabbitmq_scaledobject.yaml#L15

This should probably move to env vars like we handled all other secrets, right?

/cc @yaron2
@yaron2
Copy link
Contributor

yaron2 commented Apr 18, 2019

Correct

@jeffhollan jeffhollan added this to the Triaged milestone May 10, 2019
@jeffhollan jeffhollan added the P1 label May 10, 2019
@jeffhollan
Copy link
Member

This may be P0 only because I think it would be a breaking change?

@jeffhollan jeffhollan mentioned this issue Sep 7, 2019
Merged
@jeffhollan jeffhollan self-assigned this Sep 7, 2019
@jeffhollan jeffhollan mentioned this issue Sep 7, 2019
Merged
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
@dependabot
Bump lodash from 4.17.10 to 4.17.15 in /themes/syna/exampleSite (keda…
93bd0dd 
…core#89)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.10...4.17.15)

Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffhollan jeffhollan

Labels
P1 release-should-have
Projects
None yet
Milestone
Triaged
Development

Successfully merging a pull request may close this issue.

moving rabbitMq host to resolved value
3 participants
@ahmelsayed @jeffhollan @yaron2