Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-fix] update hack/create-cluster.sh script #3136

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Feb 9, 2023

Signed-off-by: changzhen [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

image

The cluster fails to be created using the hack/create-cluster.sh script, and the installation of the weave fails because the installation address of the weave is changed. We installed the weave to use the submarier, but now the submarier does not use the weave. For details, see here. Therefore, we also modify the weave accordingly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot requested a review from Garrybest February 9, 2023 12:49
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 9, 2023
@karmada-bot karmada-bot requested a review from lfbear February 9, 2023 12:49
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2023
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @ikaven1024

@RainbowMango
Copy link
Member

/remove-kind bug
/kind cleanup

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3136 (aee17da) into master (57236e5) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3136   +/-   ##
=======================================
  Coverage   48.00%   48.00%           
=======================================
  Files         200      200           
  Lines       18082    18082           
=======================================
  Hits         8680     8680           
  Misses       8921     8921           
  Partials      481      481           
Flag Coverage Δ
unittests 48.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@karmada-bot karmada-bot merged commit 8d3ab1c into karmada-io:master Feb 13, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the create-cluster-shell branch February 18, 2023 08:03
@RainbowMango RainbowMango changed the title [bug-fix] update clueter-cluster shell [bug-fix] update hack/create-cluster.sh script Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants