Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e for karmadactl init #3168

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Add e2e for karmadactl init #3168

merged 1 commit into from
Mar 19, 2023

Conversation

jwcesign
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Now it lacks e2e for karmadactl init, so let's add it.

Which issue(s) this PR fixes:
Fixes #3162

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 17, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2023
@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch 2 times, most recently from 87e069e to a079364 Compare February 17, 2023 07:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023 •
edited
Loading

Codecov Report

Merging #3168 (6be3dac) into master (e523977) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3168   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         202      202           
  Lines       18138    18138           
=======================================
  Hits         8827     8827           
  Misses       8822     8822           
  Partials      489      489
Flag Coverage Δ
unittests 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch 14 times, most recently from df1cab8 to 740bb64 Compare February 20, 2023 09:14
@jwcesign
Copy link
Member Author

cc @XiShanYongYe-Chang @lonelyCZ for checking

@lonelyCZ
Copy link
Member

Thanks for your works! I will look it tonight!

/assign

@lonelyCZ
Copy link
Member

It looks well running. But could we put it in CI Workflow /e2e test directly and reuse the environment? Now it looks too much items in our CI.

What do you think? @jwcesign

cc @RainbowMango @XiShanYongYe-Chang

@RainbowMango
Copy link
Member

/assign
Let me take a look

@jwcesign
Copy link
Member Author

It looks well running. But could we put it in CI Workflow /e2e test directly and reuse the environment? Now it looks too much items in our CI.

I think we can, first call deinit to uninstall the e2e env, then can init to test.

@RainbowMango
Copy link
Member

I think we can, first call deinit to uninstall the e2e env, then can init to test.

Maybe not. hold on.

@RainbowMango
Copy link
Member

Since we are going to cover more cases in the future in addition to init, I suggest organizing these tests into an individual workflow, like cli.yml.

It would be great if the new workflow could run after build(needs: build). So that the workflow could run in parallel with E2Es.

@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch 2 times, most recently from 6f17538 to d393d06 Compare March 13, 2023 06:22
@jwcesign
Copy link
Member Author

cc @RainbowMango for checking again

RainbowMango
RainbowMango reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please @XiShanYongYe-Chang @lonelyCZ take a look.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ikaven1024
Ask @ikaven1024 to take a review.

@karmada-bot karmada-bot requested a review from ikaven1024 March 15, 2023 03:39
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider using concurrency cancel-in-progress as CI Workflow.

@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch from d393d06 to 0988b7e Compare March 15, 2023 06:37
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch from 0988b7e to 59f6dee Compare March 15, 2023 07:53
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2023
@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch 5 times, most recently from 5273644 to b3c4103 Compare March 15, 2023 09:35
@jwcesign jwcesign force-pushed the add-karmadactl-init-ci branch from b3c4103 to de3476c Compare March 16, 2023 06:21
RainbowMango
RainbowMango reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ikaven1024 Do you have any other comments?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@ikaven1024
Copy link
Member

/lgtm

@ikaven1024 Do you have any other comments?

nothing else.

RainbowMango
RainbowMango approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2023
@karmada-bot karmada-bot merged commit 06a6fac into karmada-io:master Mar 19, 2023
@zhzhuang-zju zhzhuang-zju mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@ikaven1024 ikaven1024 ikaven1024 left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

Assignees

@RainbowMango RainbowMango

@lonelyCZ lonelyCZ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI for testing init command of karmadactl
7 participants
@jwcesign @codecov-commenter @lonelyCZ @RainbowMango @ikaven1024 @karmada-bot @XiShanYongYe-Chang