Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Weave #858

Closed
skitt opened this issue Jul 6, 2022 · 2 comments · Fixed by #956
Closed

Stop using Weave #858

skitt opened this issue Jul 6, 2022 · 2 comments · Fixed by #956
Assignees
@skitt
Labels
dependencies Pull requests that update a dependency file maintenance Small tasks related to ongoing maintenance release-note-needed

Comments

@skitt
Copy link
Member

skitt commented Jul 6, 2022

Weave is largely unsupported upstream, and it’s not clear we actually need it specifically; we initially added Weave so that we could work on network policy support.

We should look at the current CNI space, in particular kind-friendly CNIs, and switch to whatever seems most appropriate.
@mkolesnik
Copy link
Collaborator

How about just using the default kindnet for now?

IDK if we have any deficiencies with it, but if Weave is unsupported then using the default would be our best bet until we hit something it doesn't provide.

skitt added a commit to skitt/lighthouse that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
10beef8 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
skitt added a commit to skitt/submariner that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
44cbaff 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
skitt added a commit to skitt/shipyard that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
6b2cd2d 
See submariner-io#858.

Signed-off-by: Stephen Kitt <[email protected]>
skitt added a commit to skitt/releases that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
34455ee 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
skitt added a commit to skitt/submariner-charts that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
25097bf 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
skitt added a commit to skitt/submariner-operator that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
cfdd4ab 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
skitt added a commit to skitt/subctl that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI
68d7dba 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
This was referenced Sep 20, 2022
Merged
Merged
Merged
Merged
Merged
@skitt skitt self-assigned this Sep 20, 2022
@skitt skitt added dependencies Pull requests that update a dependency file maintenance Small tasks related to ongoing maintenance and removed next-version-candidate labels Sep 20, 2022
@skitt skitt mentioned this issue Sep 20, 2022
Merged
skitt added a commit to skitt/shipyard that referenced this issue Sep 20, 2022
@skitt
Use the default kind CNI, drop support for Weave
23963b5 
Weave is no longer actively maintained, and our tests work with the
default kind CNI. Until we need something more featureful, switch to
the default kind CNI, and remove support for Weave altogether.

See submariner-io#858.

Signed-off-by: Stephen Kitt <[email protected]>
@skitt skitt mentioned this issue Sep 20, 2022
Merged
@sridhargaddam
Copy link
Member

When deployed with default (aka kindnet), subctl CNI detection reports the CNI as "generic" but all the test-cases are passing fine. We can enhance the CNI detection code to detect and report the CNI in a future PR.

tpantelis pushed a commit to submariner-io/releases that referenced this issue Sep 20, 2022
@skitt @tpantelis
Use the default kind CNI
49c69bf 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner-charts that referenced this issue Sep 20, 2022
@skitt @tpantelis
Use the default kind CNI
aa354f7 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue Sep 20, 2022
@skitt @tpantelis
Use the default kind CNI
2d3c069 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis added a commit to tpantelis/shipyard that referenced this issue Oct 12, 2022
@tpantelis
Fix flaky e2e failures with kindnet cni
d56491b 
While transitioning to kindnet CNI in our KIND deployments,
it was seen that HostNetworking e2e tests were occasionally
failing. On debugging this issue, it was found that kindnet
CNI does not create a dedicated CNI Interface on the nodes.
Submariner relies on the CNI Interface to support some of
the use-cases like Health-check between the GW nodes and
HostNetwork to remote cluster support. However, it was seen
that as soon as we schedule a pod on the node, kindnet CNI
creates a veth-xxx interface on the Host which can be used
as a CNI Interface. So, in order to continue validating the
above Submariner use-cases, this PR schedules a dummypod as
a DaemonSet in the clusters as a workaround (and this can be
removed when we switch to a different CNI).

Fixes: submariner-io#966
Related to: submariner-io#858

Signed-off-by: Sridhar Gaddam <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/shipyard that referenced this issue Oct 12, 2022
@tpantelis
Fix flaky e2e failures with kindnet cni
d024b16 
While transitioning to kindnet CNI in our KIND deployments,
it was seen that HostNetworking e2e tests were occasionally
failing. On debugging this issue, it was found that kindnet
CNI does not create a dedicated CNI Interface on the nodes.
Submariner relies on the CNI Interface to support some of
the use-cases like Health-check between the GW nodes and
HostNetwork to remote cluster support. However, it was seen
that as soon as we schedule a pod on the node, kindnet CNI
creates a veth-xxx interface on the Host which can be used
as a CNI Interface. So, in order to continue validating the
above Submariner use-cases, this PR schedules a dummypod as
a DaemonSet in the clusters as a workaround (and this can be
removed when we switch to a different CNI).

Fixes: submariner-io#966
Related to: submariner-io#858

Signed-off-by: Sridhar Gaddam <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit that referenced this issue Oct 12, 2022
@tpantelis
Fix flaky e2e failures with kindnet cni
533179b 
While transitioning to kindnet CNI in our KIND deployments,
it was seen that HostNetworking e2e tests were occasionally
failing. On debugging this issue, it was found that kindnet
CNI does not create a dedicated CNI Interface on the nodes.
Submariner relies on the CNI Interface to support some of
the use-cases like Health-check between the GW nodes and
HostNetwork to remote cluster support. However, it was seen
that as soon as we schedule a pod on the node, kindnet CNI
creates a veth-xxx interface on the Host which can be used
as a CNI Interface. So, in order to continue validating the
above Submariner use-cases, this PR schedules a dummypod as
a DaemonSet in the clusters as a workaround (and this can be
removed when we switch to a different CNI).

Fixes: #966
Related to: #858

Signed-off-by: Sridhar Gaddam <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/shipyard that referenced this issue Oct 12, 2022
@tpantelis
Fix flaky e2e failures with kindnet cni
3550810 
While transitioning to kindnet CNI in our KIND deployments,
it was seen that HostNetworking e2e tests were occasionally
failing. On debugging this issue, it was found that kindnet
CNI does not create a dedicated CNI Interface on the nodes.
Submariner relies on the CNI Interface to support some of
the use-cases like Health-check between the GW nodes and
HostNetwork to remote cluster support. However, it was seen
that as soon as we schedule a pod on the node, kindnet CNI
creates a veth-xxx interface on the Host which can be used
as a CNI Interface. So, in order to continue validating the
above Submariner use-cases, this PR schedules a dummypod as
a DaemonSet in the clusters as a workaround (and this can be
removed when we switch to a different CNI).

Fixes: submariner-io#966
Related to: submariner-io#858

Signed-off-by: Sridhar Gaddam <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/shipyard that referenced this issue Oct 12, 2022
@tpantelis
Fix flaky e2e failures with kindnet cni
b62729d 
While transitioning to kindnet CNI in our KIND deployments,
it was seen that HostNetworking e2e tests were occasionally
failing. On debugging this issue, it was found that kindnet
CNI does not create a dedicated CNI Interface on the nodes.
Submariner relies on the CNI Interface to support some of
the use-cases like Health-check between the GW nodes and
HostNetwork to remote cluster support. However, it was seen
that as soon as we schedule a pod on the node, kindnet CNI
creates a veth-xxx interface on the Host which can be used
as a CNI Interface. So, in order to continue validating the
above Submariner use-cases, this PR schedules a dummypod as
a DaemonSet in the clusters as a workaround (and this can be
removed when we switch to a different CNI).

Fixes: submariner-io#966
Related to: submariner-io#858

Signed-off-by: Sridhar Gaddam <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit that referenced this issue Oct 12, 2022
@tpantelis
Fix flaky e2e failures with kindnet cni
557df58 
While transitioning to kindnet CNI in our KIND deployments,
it was seen that HostNetworking e2e tests were occasionally
failing. On debugging this issue, it was found that kindnet
CNI does not create a dedicated CNI Interface on the nodes.
Submariner relies on the CNI Interface to support some of
the use-cases like Health-check between the GW nodes and
HostNetwork to remote cluster support. However, it was seen
that as soon as we schedule a pod on the node, kindnet CNI
creates a veth-xxx interface on the Host which can be used
as a CNI Interface. So, in order to continue validating the
above Submariner use-cases, this PR schedules a dummypod as
a DaemonSet in the clusters as a workaround (and this can be
removed when we switch to a different CNI).

Fixes: #966
Related to: #858

Signed-off-by: Sridhar Gaddam <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis pushed a commit to tpantelis/lighthouse that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
569e2e9 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
084d99d 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
f775655 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to tpantelis/lighthouse that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
2000e78 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to tpantelis/submariner-operator that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
c23ef59 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to tpantelis/submariner-operator that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
560ca60 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
dd81362 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
52f8019 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
5efe95d 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
2e939b0 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to tpantelis/subctl that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
945d80b 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to tpantelis/submariner-charts that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
62ce1b0 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to tpantelis/submariner-charts that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
47fa64e 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/subctl that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
4000277 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner-charts that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
fd74e07 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
tpantelis pushed a commit to submariner-io/submariner-charts that referenced this issue Oct 12, 2022
@skitt @tpantelis
Use the default kind CNI
2eadbb7 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
sridhargaddam pushed a commit to sridhargaddam/releases that referenced this issue Nov 23, 2022
@skitt @sridhargaddam
Use the default kind CNI
6ff4a4b 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
(cherry picked from commit 49c69bf)
@sridhargaddam sridhargaddam mentioned this issue Nov 23, 2022
Merged
skitt added a commit to submariner-io/releases that referenced this issue Nov 23, 2022
@skitt
Use the default kind CNI
0aede8f 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
(cherry picked from commit 49c69bf)
mkolesnik pushed a commit to mkolesnik/releases that referenced this issue Dec 12, 2022
@skitt @mkolesnik
Use the default kind CNI
db002cb 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
(cherry picked from commit 49c69bf)
@mkolesnik mkolesnik mentioned this issue Dec 12, 2022
Merged
mkolesnik pushed a commit to submariner-io/releases that referenced this issue Dec 12, 2022
@skitt @mkolesnik
Use the default kind CNI
b22105a 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
(cherry picked from commit 49c69bf)
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this issue Feb 9, 2023
Merged
novad03 pushed a commit to novad03/k8s-submariner that referenced this issue Nov 25, 2023
@skitt @novad03
Use the default kind CNI
6643d40 
See submariner-io/shipyard#858.

Signed-off-by: Stephen Kitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skitt skitt

Labels
dependencies Pull requests that update a dependency file maintenance Small tasks related to ongoing maintenance release-note-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the default kind CNI, drop support for Weave skitt/shipyard
4 participants
@skitt @sridhargaddam @nyechiel @mkolesnik