-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Sync the names of the artifacts #1109
Comments
Before I make any changes here, I'd like to start a conversation about the following topics: 1 Naming convention we agree onHow about
2 Docker repositoryWhatever change we choose, changing the docker repository might be problematic. Do you know if we can do a rename and forward traffic from the old repo to the new one? Or what do you suggest? Thoughts @kairos-io/maintainers ? |
I'm guessing core is pure Kairos and standard is the one with k3s? Good to me. For normal non-device artifacts we drop the device or use a generic or something? For the docker repo...there is a way of renaming things and moving things but it's a pita. But it can be done. Redirecting seems impossible no? The repo stuff is out of our control. But we can rename it or change the repo and do a clean transition by duplicating the pushes to both repos for x versions and then finally dropping after a while |
Yeah indeed, we already do the distinction on the docs
generic sounds good to me, universal could be another option
oki will look into it |
Oh BTW we also have |
I agree on the naming, I don't know about redirections. Itxaka's suggestion on the name migration strategy sounds good. |
IIRC, I did it via skopeo. I first pulled the whole repo into local, write a script to rename the whole thing to the new repo naming and then pushed again to the new one. Supposedly it could be done with skopeo sync to sync between two repos, but I was never able to do it properly, it always mangled the names :/ |
@mudler does the proposed artifact name format work for you? |
ohh one more thing, we will also want to distinguish between community and supported ones. This is one of the action items on #1527 So maybe something like:
Where:
|
@kairos-io/maintainers ^^ |
sounds all good here. Just a note, there are non-obvious places where artifacts are hardcoded, see for e.g. ipxe, or AuroraBoot, or the agent (when finding new images) |
Something that could be beneficial IMO but maybe it's too big of a change now, is to add the underlying distro version. We currently do it only to distinguish Ubuntu "rolling" vs 20-lts and 22-lts, but I think users could benefit from knowing if the underlying distro changed between Kairos releases. For example having |
relates to kairos-io/kairos#1109 `earthly +all` ``` kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-initrd kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.ipxe kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-ipxe.iso kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-ipxe-usb.img kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.iso kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.iso.sha256 kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-kernel kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-sbom.spdx.json kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-sbom.syft.json kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.squashfs ``` `earthly +all-arm-generic --FLAVOR=opensuse-leap-arm-generic` ``` kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty.iso kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty.iso.sha256 kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty-sbom.spdx.json kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty-sbom.syft.json ``` `earthly -P +all-arm --FLAVOR=opensuse-leap-arm-rpi` ``` kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-k3s.img.xz kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-k3s.img.sha256 kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-sbom.spdx.json kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-sbom.syft.json ``` --------- Signed-off-by: Mauro Morales <[email protected]>
Renaming of repositories will not be part of this ticket but will be address in #1694 |
ok let's continue on #1694 . Closing this. |
Is your feature request related to a problem? Please describe.
Checking the release there seems to be a difference in the artifacts name that its a bit confusing
All this artifacts are for the same flavor:
core-alpine-ubuntu-v2.0.0-alpha1-grype.json
core-alpine-ubuntu-v2.0.0-alpha1-grype.sarif
core-alpine-ubuntu-v2.0.0-alpha1-sbom.spdx.json
core-alpine-ubuntu-v2.0.0-alpha1-sbom.syft.json
core-alpine-ubuntu-v2.0.0-alpha1-trivy.html
core-alpine-ubuntu-v2.0.0-alpha1-trivy.json
core-alpine-ubuntu-v2.0.0-alpha1-trivy.sarif
kairos-alpine-ubuntu-v2.0.0-alpha1-initrd
kairos-alpine-ubuntu-v2.0.0-alpha1-ipxe-usb.img.ipxe
kairos-alpine-ubuntu-v2.0.0-alpha1-ipxe.iso.ipxe
kairos-alpine-ubuntu-v2.0.0-alpha1-kernel
kairos-alpine-ubuntu-v2.0.0-alpha1.ipxe
kairos-alpine-ubuntu-v2.0.0-alpha1.iso
kairos-alpine-ubuntu-v2.0.0-alpha1.iso.sha256
kairos-alpine-ubuntu-v2.0.0-alpha1.iso.sha256.pem
kairos-alpine-ubuntu-v2.0.0-alpha1.iso.sha256.sig
kairos-alpine-ubuntu-v2.0.0-alpha1.squashfs
and its docker repo: https://quay.io/repository/kairos/core-alpine-ubuntu
Meanwhile we also have:
https://quay.io/repository/kairos/kairos-alpine-ubuntu?tab=info
For the provider-kairos.
Describe the solution you'd like
Everything to hav ethe same name. Kairos should either output
core-X
orkairos-X
or evenkairos-core-X
for all its artifacts and sync that with the repo name to avoid confusion.Describe alternatives you've considered
Keep it this way
Additional context
The text was updated successfully, but these errors were encountered: