Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introduce new artifact naming convention #466

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales commented Jul 26, 2023

relates to kairos-io/kairos#1109

earthly +all

kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-initrd
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.ipxe
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-ipxe.iso
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-ipxe-usb.img
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.iso
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.iso.sha256
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-kernel
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-sbom.spdx.json
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s-sbom.syft.json
kairos-standard-opensuse-leap-amd64-generic-v2.3.1-dirty-k3s.squashfs

earthly +all-arm-generic --FLAVOR=opensuse-leap-arm-generic

kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty.iso
kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty.iso.sha256
kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty-sbom.spdx.json
kairos-standard-opensuse-leap-arm64-generic-v2.3.1-1-g6a62b88-dirty-sbom.syft.json

earthly -P +all-arm --FLAVOR=opensuse-leap-arm-rpi

kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-k3s.img.xz
kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-k3s.img.sha256
kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-sbom.spdx.json
kairos-standard-opensuse-leap-arm64-rpi64-v2.3.1-3-g4b23855-dirty-sbom.syft.json

Signed-off-by: Mauro Morales <[email protected]>
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #466 (7e12683) into main (360f1f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   12.27%   12.27%           
=======================================
  Files          17       17           
  Lines        1075     1075           
=======================================
  Hits          132      132           
  Misses        916      916           
  Partials       27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
@mauromorales mauromorales changed the title [WIP] ✨ Introduce new artifact naming convention ✨ Introduce new artifact naming convention Jul 27, 2023
@mauromorales mauromorales marked this pull request as ready for review July 27, 2023 08:29
@mauromorales mauromorales self-assigned this Jul 27, 2023
@mauromorales mauromorales requested a review from a team July 27, 2023 08:30
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@jimmykarily
Copy link
Contributor

I'm trying to move the release of the image artifacts to kairos-io/kairos here: https://github.com/kairos-io/kairos/compare/master..1609-release-standard-images

If that's done, most of the artifacts (other than the binary itself) wouldn't be produced by this repository anymore. But let's keep this open until the work on kairos is done. I will use this as a guide on how the final artifact should be named.

@mauromorales
Copy link
Member Author

@jimmykarily can we do it the other way around? can we merge this, so they are in sync with the artifacts on kairos repo? And then you base your changes on this one

@mauromorales mauromorales merged commit 54532e7 into main Jul 27, 2023
@mauromorales mauromorales deleted the 1109-sync-artifact-names branch July 27, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants