Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifacts naming doc #55

Merged
merged 12 commits into from
Sep 15, 2023
Merged

Add artifacts naming doc #55

merged 12 commits into from
Sep 15, 2023

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales commented Jul 19, 2023

⚠️ let's merge this until all the changes to the artifacts are done, so we don't have to open fixes in case something changes

Relates to kairos-io/kairos#1109

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for kairos-io ready!

Name Link
🔨 Latest commit ecd72d0
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/64c77ef0aaecd5000703923d
😎 Deploy Preview https://deploy-preview-55--kairos-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mauromorales mauromorales self-assigned this Jul 19, 2023
@mauromorales mauromorales requested a review from a team July 19, 2023 15:53
Signed-off-by: Mauro Morales <[email protected]>
content/en/docs/Reference/artifacts.md Outdated Show resolved Hide resolved
content/en/docs/Reference/artifacts.md Outdated Show resolved Hide resolved
content/en/docs/Reference/artifacts.md Outdated Show resolved Hide resolved
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
@jimmykarily
Copy link
Contributor

We can merge this PR after the implementation is done: kairos-io/kairos#1109

Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>

### Examples

- quay.io/kairos/core-ubuntu-generic:v1.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmykarily according to the discussion today we will use tags for the support of the image. Do you know how that looks in the end? Maybe something like:

quay.io/kairos/core-ubuntu-generic:community-v1.0.0

and if that is the case, should we also move the model into the tag?

quay.io/kairos/core-ubuntu-generic:community-generic-v1.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool, I didn't know about this one ... and you can filter them to download? And if so, the question would still apply, should we only have a quay.io/kairos/core-ubuntu:v1.0.0 and you somehow pass labels to filter even further

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you can filter them locally: https://docs.docker.com/engine/reference/commandline/images/#filter
And the web UI of the registry might let you see the labels. But I don't think anyone will be downloading in batches so they would first identify the image they want and then download it, so no need for filtering (?).

An image will be, either community or "official" not both. So they just need to check the label for the image they are interested in.

@mauromorales
Copy link
Member Author

mauromorales commented Aug 14, 2023

This is just waiting for the 2.4.0 release with the new artifacts names

@Itxaka
Copy link
Member

Itxaka commented Sep 15, 2023

This is done now!

@Itxaka Itxaka merged commit f61af7f into main Sep 15, 2023
@Itxaka Itxaka deleted the artifacts branch September 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants