-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add artifacts naming doc #55
Conversation
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
…elease Signed-off-by: Mauro Morales <[email protected]>
We can merge this PR after the implementation is done: kairos-io/kairos#1109 |
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
|
||
### Examples | ||
|
||
- quay.io/kairos/core-ubuntu-generic:v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmykarily according to the discussion today we will use tags for the support of the image. Do you know how that looks in the end? Maybe something like:
quay.io/kairos/core-ubuntu-generic:community-v1.0.0
and if that is the case, should we also move the model into the tag?
quay.io/kairos/core-ubuntu-generic:community-generic-v1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not "tags", "labels". Like these: https://docs.docker.com/engine/reference/builder/#label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, I didn't know about this one ... and you can filter them to download? And if so, the question would still apply, should we only have a quay.io/kairos/core-ubuntu:v1.0.0
and you somehow pass labels to filter even further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you can filter them locally: https://docs.docker.com/engine/reference/commandline/images/#filter
And the web UI of the registry might let you see the labels. But I don't think anyone will be downloading in batches so they would first identify the image they want and then download it, so no need for filtering (?).
An image will be, either community or "official" not both. So they just need to check the label for the image they are interested in.
This is just waiting for the 2.4.0 release with the new artifacts names |
This is done now! |
Relates to kairos-io/kairos#1109