Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend AMP Params #62

Merged
merged 23 commits into from
Jul 9, 2021
Merged

Extend AMP Params #62

merged 23 commits into from
Jul 9, 2021

Commits on Jun 4, 2021

  1. Add setup method

    @mamaddox
    mamaddox committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    68460a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. create separate postMessage method and add setup test

    @mamaddox
    mamaddox committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    dc9d821 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. adding support for data-params and querystring

    @Dawolee
    Dawolee committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2a79c47 View commit details
    Browse the repository at this point in the history

  2. adding support for data-params and querystring

    @Dawolee
    Dawolee committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    16657fc View commit details
    Browse the repository at this point in the history

  3. updating tests for data-params

    @Dawolee
    Dawolee committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    089895c View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. re-adding unit test i accidentally removed

    @Dawolee
    Dawolee committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d0768f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Pass custom config added through amp to player

    @mamaddox
    mamaddox committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    8fce30c View commit details
    Browse the repository at this point in the history

  2. Use correct import format

    @mamaddox
    mamaddox committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    a3d4b5d View commit details
    Browse the repository at this point in the history

  3. updated attribute names

    @Dawolee
    Dawolee committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    254c5bf View commit details
    Browse the repository at this point in the history

  4. adding code suggestions

    @Dawolee
    Dawolee committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    9d6052d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Add test coverage and fix formatting

    @mamaddox
    mamaddox committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    4137150 View commit details
    Browse the repository at this point in the history

  2. Move test config to above assertation

    @mamaddox
    mamaddox committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    779292f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Update media id and player id for vast ad config

    @mamaddox
    mamaddox committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8d2c02a View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Add cust-params data attribute for ads

    @mamaddox
    mamaddox committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    e6fa4cd View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Merge pull request #58 from jwplayer/feature/jwplayer-ad-cust-params 

    ✨ ✅ [JW8-11876] Add cust-params data attribute for ads
    @mamaddox
    mamaddox authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    6408113 View commit details
    Browse the repository at this point in the history

  2. testing

    @Dawolee
    Dawolee committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    2928830 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Integrate with amp-consent and add custom macros

    @mamaddox
    mamaddox committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    f2e7510 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Merge pull request #60 from jwplayer/feature/jwplayer-ad-macros-consent 

    [JW8-11900][JW8-11872] Integrate with amp-consent and add custom macros
    @mamaddox
    mamaddox authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    729b663 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #44 from jwplayer/task/jwplayer-add-setup 

    [JW8-11877][JW8-11874] Add setup method to amp-jwplayer
    @mamaddox
    mamaddox authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a99aa89 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #59 from jwplayer/task/update-event-mappings 

    [JW8-11935] Additional play event firing during pre-roll ads
    @mamaddox
    mamaddox authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    979c5dd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/jwplayer-add-new-params' into dlee_data_params

    @mamaddox
    mamaddox authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7a82853 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #55 from jwplayer/dlee_data_params 

    [JW8-11875]✨ ✅Adding support for data-params and data-media-querystring
    @mamaddox
    mamaddox authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d903de9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Lint fixes

    @mamaddox
    mamaddox committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    6a582bb View commit details
    Browse the repository at this point in the history