Extend AMP Params #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ ✅ [JW8-11876] Add cust-params data attribute for ads
[JW8-11900][JW8-11872] Integrate with amp-consent and add custom macros
[JW8-11877][JW8-11874] Add setup method to amp-jwplayer
[JW8-11935] Additional play event firing during pre-roll ads
[JW8-11875]✨ ✅Adding support for data-params and data-media-querystring
mamaddox
added a commit
that referenced
this pull request
Jul 26, 2021
* Add setup method * create separate postMessage method and add setup test * adding support for data-params and querystring * updating tests for data-params * re-adding unit test i accidentally removed * Pass custom config added through amp to player * Use correct import format * updated attribute names * adding code suggestions * Add test coverage and fix formatting * Move test config to above assertation * Update media id and player id for vast ad config * Add cust-params data attribute for ads * testing * Integrate with amp-consent and add custom macros * Lint fixes Co-authored-by: Daniel Lee <[email protected]>
mamaddox
added a commit
that referenced
this pull request
Jul 27, 2021
* Add setup method * create separate postMessage method and add setup test * adding support for data-params and querystring * updating tests for data-params * re-adding unit test i accidentally removed * Pass custom config added through amp to player * Use correct import format * updated attribute names * adding code suggestions * Add test coverage and fix formatting * Move test config to above assertation * Update media id and player id for vast ad config * Add cust-params data attribute for ads * testing * Integrate with amp-consent and add custom macros * Lint fixes Co-authored-by: Daniel Lee <[email protected]>
zetagame
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Add JW Player to documentation that applies * Revert "Add JW Player to documentation that applies" This reverts commit 5aeba5a. * Extend AMP Params (#62) * Add setup method * create separate postMessage method and add setup test * adding support for data-params and querystring * updating tests for data-params * re-adding unit test i accidentally removed * Pass custom config added through amp to player * Use correct import format * updated attribute names * adding code suggestions * Add test coverage and fix formatting * Move test config to above assertation * Update media id and player id for vast ad config * Add cust-params data attribute for ads * testing * Integrate with amp-consent and add custom macros * Lint fixes Co-authored-by: Daniel Lee <[email protected]> * Remove bad import * Clean up consentgdpr * Add comment about appending querystring * Clean up from rebase * Remove trailing whitespaces * Remove controls attribute * 📖 [JW8-11873] Update JW Player AMP Docs (#61) Update our amp-jwplayer docs with the new attributes Add amp-jwplayer in the docs where it applies * cleanup rebase * lint fixes Co-authored-by: Zack Haigh <[email protected]> Co-authored-by: Daniel Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled PR