[JW8-11875]✨ ✅Adding support for data-params and data-media-querystring #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamaddox
changed the title
mamaddox
reviewed
Jun 15, 2021
examples/jwplayer.amp.html
Outdated
| <amp-jwplayer | ||
| data-media-id="BZ6tc0gy" | ||
| data-player-id="uoIbMPm3" | ||
| data-media-querystring='name1=abc&name2=xyz&name3=123' |
There was a problem hiding this comment.
This is a fault on my side and I'll update the ticket, but let's rename these params to data-player-querystring and data-player-param since they are appended to the player embed url.
mamaddox
reviewed
Jun 15, 2021
mamaddox
reviewed
Jun 15, 2021
|
Merge conflict @Dawolee |
mamaddox
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to add support for data-params and data-media-querystring attributes. New demo and tests have been added as well.