Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storage_impl): split payment attempt models to domain + diesel #2010

Merged
merged 43 commits into from
Sep 11, 2023
Merged

refactor(storage_impl): split payment attempt models to domain + diesel #2010

merged 43 commits into from
Sep 11, 2023

Conversation

lsampras
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Creating mirror structs for payment attempt &mandate in data_models
  • move needed kv util functions to storage_impl

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added A-core Area: Core flows C-refactor Category: Refactor labels Aug 24, 2023
@lsampras lsampras self-assigned this Aug 24, 2023
@lsampras lsampras marked this pull request as ready for review August 24, 2023 15:55
@lsampras lsampras requested review from a team, jarnura and ashokkjag as code owners August 24, 2023 15:55
ThisIsMani
ThisIsMani previously approved these changes Aug 28, 2023
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/connector/nuvei/transformers.rs Show resolved Hide resolved
crates/router/src/core/payments.rs Show resolved Hide resolved
@SanchithHegde SanchithHegde dismissed their stale review August 30, 2023 17:51

Meant to leave review comments only, my bad

@harsh-sharma-juspay harsh-sharma-juspay added S-ready-for-merge and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Sep 8, 2023
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-ready-for-merge labels Sep 10, 2023
SanchithHegde
SanchithHegde previously approved these changes Sep 11, 2023
View reviewed changes
@lsampras lsampras added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Sep 11, 2023
@lsampras lsampras added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit ad4b7de Sep 11, 2023
10 checks passed
@lsampras lsampras deleted the split_payment_attempt branch September 11, 2023 12:14
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivor11 ivor11 ivor11 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@harsh-sharma-juspay harsh-sharma-juspay harsh-sharma-juspay left review comments

@ThisIsMani ThisIsMani ThisIsMani left review comments

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@vspecky vspecky Awaiting requested review from vspecky

Assignees

@lsampras lsampras

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.