-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Paypal] add support for payment and refund webhooks #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujanchikke
added
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
P-high
Priority: High
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Aug 24, 2023
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
requested review from
jarnura,
ashokkjag and
a team
as code owners
August 24, 2023 08:07
ArjunKarthik
previously approved these changes
Aug 24, 2023
@prasunna09 Please add the query to move order_id to connector_transaction_id and connector_transaction_id to capture_id in connector_meta_data Rest looks fine |
ArjunKarthik
previously approved these changes
Aug 25, 2023
SanchithHegde
previously approved these changes
Aug 25, 2023
prasunna09
added
S-ready-for-merge
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Aug 26, 2023
prasunna09
previously approved these changes
Aug 28, 2023
sai-harsha-vardhan
requested changes
Aug 28, 2023
srujanchikke
dismissed stale reviews from prasunna09 and SanchithHegde
via
August 28, 2023 09:39
eecb2fe
sai-harsha-vardhan
approved these changes
Aug 28, 2023
ArjunKarthik
approved these changes
Aug 28, 2023
SanchithHegde
approved these changes
Aug 28, 2023
lsampras
pushed a commit
that referenced
this pull request
Sep 4, 2023
…#2003) Signed-off-by: chikke srujan <[email protected]> Co-authored-by: Prasunna Soppa <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
authorize_id
orcapture_id
are stored in connector transaction id , now it's been changed toorder_id
(Reason :order_id
is the only constant id that is being sent in webhooks)Additional Changes
Motivation and Context
How did you test it?
Payment Webhook
Refund Webhook
Checklist
cargo +nightly fmt --all
cargo clippy