Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Paypal] add support for payment and refund webhooks #2003

Merged
merged 10 commits into from
Aug 29, 2023

Conversation

srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Aug 24, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. add support for payment and refund webhooks for paypal. As of now source verification is set to false when additional apicall flow for verification is implemented , source verification will be taken care .
  2. this pr also modifies connector transaction id for paypal . Before authorize_id or capture_id are stored in connector transaction id , now it's been changed to order_id(Reason : order_id is the only constant id that is being sent in webhooks)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Payment Webhook
Screenshot 2023-08-24 at 1 09 58 PM
Refund Webhook
Screenshot 2023-08-25 at 3 03 37 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 24, 2023
@srujanchikke srujanchikke requested a review from a team as a code owner August 24, 2023 07:58
@srujanchikke srujanchikke self-assigned this Aug 24, 2023
@srujanchikke srujanchikke requested a review from a team as a code owner August 24, 2023 07:58
ArjunKarthik
ArjunKarthik previously approved these changes Aug 24, 2023
@ArjunKarthik
Copy link
Contributor

@prasunna09 Please add the query to move order_id to connector_transaction_id and connector_transaction_id to capture_id in connector_meta_data

Rest looks fine

ArjunKarthik
ArjunKarthik previously approved these changes Aug 25, 2023
SanchithHegde
SanchithHegde previously approved these changes Aug 25, 2023
@prasunna09 prasunna09 added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 26, 2023
prasunna09
prasunna09 previously approved these changes Aug 28, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit ade27f0 Aug 29, 2023
9 of 10 checks passed
@ArjunKarthik ArjunKarthik deleted the paypal-webhooks branch August 29, 2023 05:31
lsampras pushed a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants