chore: address Rust 1.72 clippy lints #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
S-waiting-on-review
SanchithHegde
requested review from
a team,
jarnura and
ashokkjag
as code owners
lsampras
previously approved these changes
Aug 24, 2023
SanchithHegde
commented
Aug 24, 2023
.cargo/config.toml
Outdated
| @@ -1,4 +1,4 @@ | |||
| [target.'cfg(all())'] | |||
| [build] | |||
There was a problem hiding this comment.
With [target.'cfg(all())'], all allowed lints (such as as conversions, missing panics docs, etc.) were somehow still raising warnings.
I'm not sure if there are any cons of using the build table for this purpose, I'll raise this issue on EmbarkStudios/rust-ecosystem#59, will update this as required.
ArjunKarthik
previously approved these changes
Aug 24, 2023
SanchithHegde
dismissed stale reviews from ArjunKarthik and lsampras
via
69c0b8d
|
Weird enough, I'm able to get this to pass |
lsampras
previously approved these changes
Aug 25, 2023
lsampras
removed
the
S-waiting-on-review
ashokkjag
previously approved these changes
Aug 25, 2023
lsampras
approved these changes
Aug 28, 2023
ThisIsMani
approved these changes
Aug 28, 2023
ArjunKarthik
approved these changes
Aug 28, 2023
lsampras
added a commit
that referenced
this pull request
Sep 4, 2023
Co-authored-by: Sampras Lopes <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR addresses a clippy lint stabilized in Rust 1.72.
Motivation and Context
N/A
How did you test it?
N/A
Checklist
cargo +nightly fmt --allcargo clippy