Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Python packages names #119

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Normalize Python packages names #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fe826f
Normalize Python packages names
jtpio Feb 22, 2024
70717de
bump top-level for now
jtpio Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jupyterlab-topbar-extensions",
"version": "1.0.0",
"version": "1.0.1",
mahendrapaipuri marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump this manually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check-release job fails otherwise: #114

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we should handle that better (as part of #114)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!! We need to improve this. Do you know if there are any features added in jupyter-releaser to handle monorepos? I will take a look into it as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monorepos of JS packages should work fine. However it's a bit more tricky with Python monorepos.

There are some issues on the releaser repo somehow related:

This would also be useful for releasing ipywidgets with the releaser: jupyter-widgets/ipywidgets#3285

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the links. I think a custom script to handle Python packages as you suggested in jupyter_releaser#496 can be viable option.

I can look into it in the next weeks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

"private": true,
"files": [],
"workspaces": [
Expand Down
2 changes: 1 addition & 1 deletion packages/logout-extension/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = ["hatchling>=1.5.0", "jupyterlab>=4.0.0,<5", "hatch-nodejs-version"]
build-backend = "hatchling.build"

[project]
name = "jupyterlab-logout"
name = "jupyterlab_logout"
readme = "README.md"
license = { file = "LICENSE" }
requires-python = ">=3.8"
Expand Down
2 changes: 1 addition & 1 deletion packages/theme-toggler-extension/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = ["hatchling>=1.5.0", "jupyterlab>=4.0.0,<5", "hatch-nodejs-version"]
build-backend = "hatchling.build"

[project]
name = "jupyterlab-theme-toggler"
name = "jupyterlab_theme_toggler"
readme = "README.md"
license = { file = "LICENSE" }
requires-python = ">=3.8"
Expand Down
2 changes: 1 addition & 1 deletion packages/topbar-text-extension/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = ["hatchling>=1.5.0", "jupyterlab>=4.0.0,<5", "hatch-nodejs-version"]
build-backend = "hatchling.build"

[project]
name = "jupyterlab-topbar-text"
name = "jupyterlab_topbar_text"
readme = "README.md"
license = { file = "LICENSE" }
requires-python = ">=3.8"
Expand Down
Loading