-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize Python packages names #119
Normalize Python packages names #119
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "jupyterlab-topbar-extensions", | |||
"version": "1.0.0", | |||
"version": "1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to bump this manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check-release job fails otherwise: #114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we should handle that better (as part of #114)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!! We need to improve this. Do you know if there are any features added in jupyter-releaser
to handle monorepos? I will take a look into it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monorepos of JS packages should work fine. However it's a bit more tricky with Python monorepos.
There are some issues on the releaser repo somehow related:
- new version-mode option for monorepo versioning jupyter-server/jupyter_releaser#496
- Allow skipping
pip install
step incheck-python
jupyter-server/jupyter_releaser#499
This would also be useful for releasing ipywidgets
with the releaser: jupyter-widgets/ipywidgets#3285
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers for the links. I think a custom script to handle Python packages as you suggested in jupyter_releaser#496 can be viable option.
I can look into it in the next weeks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks!
Closes #117