Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Python packages names #119

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 22, 2024

Closes #117

@jtpio
Copy link
Member Author

jtpio commented Feb 22, 2024

The packages seem to be published correctly to the test PyPI server now:

image

@jtpio jtpio marked this pull request as ready for review February 22, 2024 16:38
package.json Show resolved Hide resolved
@@ -1,6 +1,6 @@
{
"name": "jupyterlab-topbar-extensions",
"version": "1.0.0",
"version": "1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump this manually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check-release job fails otherwise: #114

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we should handle that better (as part of #114)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!! We need to improve this. Do you know if there are any features added in jupyter-releaser to handle monorepos? I will take a look into it as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monorepos of JS packages should work fine. However it's a bit more tricky with Python monorepos.

There are some issues on the releaser repo somehow related:

This would also be useful for releasing ipywidgets with the releaser: jupyter-widgets/ipywidgets#3285

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the links. I think a custom script to handle Python packages as you suggested in jupyter_releaser#496 can be viable option.

I can look into it in the next weeks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@jtpio
Copy link
Member Author

jtpio commented Feb 22, 2024

@mahendrapaipuri mahendrapaipuri merged commit 7896ffb into jupyterlab-contrib:main Feb 23, 2024
13 checks passed
@jtpio jtpio deleted the rename-packages branch February 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python package names do not match with names declared in jupyter-releaser config
2 participants