Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping pip install step in check-python #499

Open
jtpio opened this issue Mar 16, 2023 · 1 comment
Open

Allow skipping pip install step in check-python #499

jtpio opened this issue Mar 16, 2023 · 1 comment

Comments

@jtpio
Copy link
Member

jtpio commented Mar 16, 2023

Current the check-python step also tries to install the packages in a new environment with pip:

# Create the virtual env, upgrade pip,
# install, and run test command
util.run(f"python -m venv {env_path}")
util.run(f"{bin_path}/python -m pip install -q -U pip")
util.run(f"{bin_path}/pip install -q {dist_file}")

This can cause issues in Python monorepos with packages depending on each other with lower bounds, for example:

  • package foo, version 0.1.2, has no dependency
  • package bar, version 0.1.2 has a dependency on foo >= 0.1.2

When trying to install bar in the check-python, package foo==0.1.2 has not yet been released and bar cannot be installed.

This might also be related to #371 and #372, although not sure if they still applied after the switch to releaser v2.

@jtpio jtpio changed the title Allow skipping pip install step in the Python check_dist Allow skipping pip install step in check-python Mar 16, 2023
@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2023

An alternative could also be to allow for passing extra args (for example --no-deps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant