Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken link icon to work in FontAwesome 4 and 5 #3476

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

jasongrout
Copy link
Member

#3475 fixed the broken link icon for FontAwesome 5, but unfortunately things broke for FontAwesome 4 (i.e., classic Notebook). This uses CSS that works for both FontAwesome 4 and FontAwesome 5, so the broken link works in classic notebook and JupyterLab.

As it currently is, the icon works for JupyterLab 3, but not Notebook 6. This fixes the icon to work both in Notebook 6 (FontAwesome 4) and JupyterLab 3 (FontAwesome 5).
@jasongrout jasongrout added this to the 8.0 milestone Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Binder 👈 Launch a binder notebook on branch jasongrout/ipywidgets/linkicon

@ibdafna ibdafna merged commit 575ce74 into jupyter-widgets:master Jun 13, 2022
@jasongrout
Copy link
Member Author

@meeseeksdev please backport to 7.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 13, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 575ce74c8b53764d6a8173d1c709fae27c8c9ec6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3476: Update broken link icon to work in FontAwesome 4 and 5'
  1. Push to a named branch:
git push YOURFORK 7.x:auto-backport-of-pr-3476-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #3476 on branch 7.x (Update broken link icon to work in FontAwesome 4 and 5)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jasongrout
Copy link
Member Author

Backported to 7.x in #3495

jasongrout added a commit that referenced this pull request Jun 22, 2022
Backport PR #3476: Update broken link icon to work in FontAwesome 4 and 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants