-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken link icon to work in FontAwesome 4 and 5 #3476
Conversation
As it currently is, the icon works for JupyterLab 3, but not Notebook 6. This fixes the icon to work both in Notebook 6 (FontAwesome 4) and JupyterLab 3 (FontAwesome 5).
@meeseeksdev please backport to 7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…FontAwesome 4 and 5
Backported to 7.x in #3495 |
Backport PR #3476: Update broken link icon to work in FontAwesome 4 and 5
#3475 fixed the broken link icon for FontAwesome 5, but unfortunately things broke for FontAwesome 4 (i.e., classic Notebook). This uses CSS that works for both FontAwesome 4 and FontAwesome 5, so the broken link works in classic notebook and JupyterLab.