Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update broken link icon to work in FontAwesome 4 and 5 #3476

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Update broken link icon to work in FontAwesome 4 and 5 #3476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d50fadc
Make broken link icon work for both fontawesome 4 and fontawesome 5.
jasongrout Jun 7, 2022
33f1f5d
Adjust broken link line spacing to look better in JupyterLab.
jasongrout Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/base/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
.jupyter-widgets-disconnected::before {
content: '\f127'; /* chain-broken */
display: inline-block;
font: normal normal 900 14px/1px 'Font Awesome 5 Free';
font-size: inherit;
font: normal normal 900 14px/1 'Font Awesome 5 Free', 'FontAwesome';
text-rendering: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
Expand Down
5 changes: 0 additions & 5 deletions packages/controls/css/widgets-base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@
overflow: visible;
}

.jupyter-widgets.jupyter-widgets-disconnected::before {
line-height: var(--jp-widgets-inline-height);
height: var(--jp-widgets-inline-height);
}

.jp-Output-result > .jupyter-widgets {
margin-left: 0;
margin-right: 0;
Expand Down