Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 3466 - Disconnect broken link problems #3475

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

kellietay
Copy link

@kellietay kellietay commented Jun 6, 2022

PR Summary:
Issue #3466 mentions 2 issues. This PR specifically only fixes issue 1 - "When restarting, the broken link icon is, well, broken in jupyterlab."

Fix Description:

  • updated font-weight to 900 as FontAwesome now only allows font-weight 900 as part of its free plans.

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Binder 👈 Launch a binder notebook on branch kellietay/ipywidgets/ipywidgets-issue-3466

@ibdafna
Copy link
Member

ibdafna commented Jun 6, 2022

@kellietay Thank you so much for the contribution 🎉

For further context, Kellie submitted this PR as a part of our small Jupyter-widgets workshop for new contributors at Bloomberg (see doc here: https://hackmd.io/@2PcPw1J9RgyxBaean6VEfw/SkMVqii_q)

@jasongrout
Copy link
Member

Thanks!
Screen Shot 2022-06-06 at 21 32 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants