Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete display_model and display_view #2752

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Delete display_model and display_view #2752

merged 4 commits into from
Feb 11, 2020

Commits on Jan 25, 2020

  1. Initial attempt at deleting display_model and display_view. 

    Fixes jupyter-widgets#2751
    @jasongrout
    jasongrout committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    159bbe4 View commit details
    Browse the repository at this point in the history

  2. More work on deleting display_view and display_model. 

    I decided to keep a display_view on the html manager for convenience, so people do not have to figure out how to use Lumino widget attach functions, or deal with Lumino widgets at all (which does mean that people are likely to not trigger resize messages properly too…)
    @jasongrout
    jasongrout committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    2864b0c View commit details
    Browse the repository at this point in the history

  3. Fix testing errors

    @jasongrout
    jasongrout committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    3ed2f44 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2020

  1. Adjust waiting time in test.

    @jasongrout
    jasongrout committed Jan 26, 2020
    Configuration menu
    Copy the full SHA
    6d297ea View commit details
    Browse the repository at this point in the history