Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display_view and display_model used inconsistently #2751

Closed
jasongrout opened this issue Jan 25, 2020 · 0 comments · Fixed by #2752
Closed

display_view and display_model used inconsistently #2751

jasongrout opened this issue Jan 25, 2020 · 0 comments · Fixed by #2752
Labels
backwards-incompatible resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
8.0

Comments

@jasongrout
Copy link
Member

We discovered in #2657 (comment) that display_view is used inconsistently throughout the codebase. In discussion at the widgets sprint in Paris, we decided to explore getting rid of display_view (and display_model?), and instead just having create_view.
@jasongrout jasongrout added this to the 8.0 milestone Jan 25, 2020
jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Jan 25, 2020
@jasongrout
Initial attempt at deleting display_model and display_view.
159bbe4 
Fixes jupyter-widgets#2751
@jasongrout jasongrout mentioned this issue Jan 25, 2020
Merged
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backwards-incompatible resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Delete display_model and display_view jasongrout/ipywidgets
1 participant
@jasongrout