-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ESLint and Prettier #2657
Conversation
Another thing that would be great to do would be to unify the naming of variables, function parameters and so on, to have a consistent style. At the moment, the TypeScript code uses a mix of camel case and snake case. This could also be done in a separate PR (if so we can open a new issue). And it can be a quite big breaking change if the API ( |
It still doesn’t work, but let’s make that a different PR.
The one thing left is a failing test in web3, which exposes that we are not consistent at all in how we define and use our widget manager display_view function. Let's talk about this tomorrow. |
Current failing lints will be fixed in a follow-up PR to avoid further conflicts :) |
This is a WIP PR to move to eslint and prettier for code linting.