Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ESLint and Prettier #2657

Merged
merged 18 commits into from
Jan 8, 2020
Merged

Conversation

jasongrout
Copy link
Member

This is a WIP PR to move to eslint and prettier for code linting.

@jasongrout jasongrout added the Work in Progress PRs that are not ready to be reviewed/merged. label Jan 3, 2020
@jtpio
Copy link
Member

jtpio commented Jan 6, 2020

Another thing that would be great to do would be to unify the naming of variables, function parameters and so on, to have a consistent style.

At the moment, the TypeScript code uses a mix of camel case and snake case.

This could also be done in a separate PR (if so we can open a new issue). And it can be a quite big breaking change if the API (save_changes as an example) is also modified.

@jasongrout jasongrout marked this pull request as ready for review January 7, 2020 18:41
@jasongrout
Copy link
Member Author

The one thing left is a failing test in web3, which exposes that we are not consistent at all in how we define and use our widget manager display_view function. Let's talk about this tomorrow.

@jasongrout jasongrout mentioned this pull request Jan 8, 2020
@vidartf vidartf removed the Work in Progress PRs that are not ready to be reviewed/merged. label Jan 8, 2020
@vidartf vidartf merged commit 60c2d39 into jupyter-widgets:master Jan 8, 2020
@vidartf
Copy link
Member

vidartf commented Jan 8, 2020

Current failing lints will be fixed in a follow-up PR to avoid further conflicts :)

@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@jasongrout jasongrout deleted the eslint branch February 17, 2021 07:03
@jasongrout jasongrout added this to the 8.0 milestone Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants